Bug 73954 – REGRESSION (r97745): Transitions don't work on links

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[@fregante]

Properties are not transitioned on links and their children.

Chrome 17.0.942.0 dev/Mac

[Tim Horton]

I've bisected this and it looks like http://trac.webkit.org/changeset/97745/trunk might be the culprit.

[Tim Horton]

Created attachment 118233 [details]
repro (without jquery/jsfiddle)

[Antti Koivisto]

Thanks, I'll take a look.

[Antti Koivisto]

The test case seems to work fine in Safari with ToT WebKit.

[Tim Horton]

(In reply to comment #4)
> The test case seems to work fine in Safari with ToT WebKit.

Really? On Safari + WebKit r102386, I get a sharp transition on the right element (the link with a target), and a smooth one on the left element (the link without a target).

[Antti Koivisto]

(In reply to comment #5)
> Really? On Safari + WebKit r102386, I get a sharp transition on the right element (the link with a target), and a smooth one on the left element (the link without a target).

After a few retries it suddenly it started happening.  Strange. Anyway, I see it now.

[Antti Koivisto]

Created attachment 119111 [details]
patch

[Antti Koivisto]

(In reply to comment #6)
> After a few retries it suddenly it started happening.  Strange. Anyway, I see it now.

It was actually having to click the link so it became visited.

[Andreas Kling]

Comment on attachment 119111 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=119111&action=review

> Source/WebCore/rendering/style/RenderStyle.h:1631
> +    const Color& visitedLinkColumnRuleColor() const { return rareNonInheritedData->m_multiCol->m_visitedLinkColumnRuleColor; }
> +    const Color& visitedLinkTextEmphasisColor() const { return rareInheritedData->visitedLinkTextEmphasisColor; }
> +    const Color& visitedLinkTextFillColor() const { return rareInheritedData->visitedLinkTextFillColor; }
> +    const Color& visitedLinkTextStrokeColor() const { return rareInheritedData->visitedLinkTextStrokeColor; }

We should cover these colors in the layout test as well.

[Antti Koivisto]

trac.webkit.org/changeset/103192