[CHROMIUM/SKIA] Handle put[Un|Pre]multipliedImageData conversions in Skia rather than ImageBuffer
Created attachment 118113 [details] Patch
Created attachment 118116 [details] Failing test output
Comment on attachment 118113 [details] Patch IWBN to be value-preserving over one get/put roundtrip (the way the software implementation is). But the perf win is probably worth breaking this for now. r=me
Comment on attachment 118113 [details] Patch Clearing flags on attachment: 118113 Committed r102244: <http://trac.webkit.org/changeset/102244>
All reviewed patches have been landed. Closing bug.
Reopening this issue. The original patch was reverted because it triggered asserts in skia that premultiplied pixels actually are premultiplied. The svg/dynamic-updates/SVGFEDropShadow* tests generate data that is supposed to be premultiplied but isn't. The asserts now are disabled in skia and bug 74025 has been filed against the tests.
Comment on attachment 118113 [details] Patch Clearing flags on attachment: 118113 Committed r102782: <http://trac.webkit.org/changeset/102782>
The ChangeLog tells me nothing about why this change happened, and there are no performance numbers given for the s/w or h/w paths. Do we have numbers? And it seems the h/w path breaks get/put round-tripping, per bug 73952.