Bug 73942 - webkitpy provides no way to specify the PID of the crashed process whose crash log you want to find
Summary: webkitpy provides no way to specify the PID of the crashed process whose cras...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords:
Depends on:
Blocks: 71380
  Show dependency tree / graph
 
Reported: 2011-12-06 11:54 PST by Adam Roben (:aroben)
Modified: 2011-12-08 08:30 PST (History)
5 users (show)

See Also:

Attachments
Patch (10.08 KB, patch)
2011-12-06 11:59 PST, Adam Roben (:aroben) 		dpranke: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-12-06 11:54:56 PST 
webkitpy provides no way to specify the PID of the crashed process whose crash log you want to find
Comment 1 Adam Roben (:aroben) 2011-12-06 11:59:29 PST 
Created attachment 118086 [details]
Patch
Comment 2 Adam Roben (:aroben) 2011-12-06 12:04:46 PST 
Committed r102163: <http://trac.webkit.org/changeset/102163>
Comment 3 Eric Seidel (no email) 2011-12-06 14:15:35 PST 
Comment on attachment 118086 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=118086&action=review

> Tools/ChangeLog:17
> +        (CrashLogs.find_newest_log): Added an optional pid parameter.
> +        (CrashLogs._find_newest_log_darwin): Added a pid parameter. When specified, we look at each
> +        candidate log's app_description extended attribute to see if that log corresponds to a
> +        crashed process with the specified PID.

I'm surprised you do this via xattr instead of just parsing the text files.
Comment 4 Eric Seidel (no email) 2011-12-06 14:15:51 PST 
Does this work on SL as well as Lion?
Comment 5 Adam Roben (:aroben) 2011-12-06 20:37:19 PST 
(In reply to comment #3)
> I'm surprised you do this via xattr instead of just parsing the text files.

I figured xattr would be faster.

(In reply to comment #4)
> Does this work on SL as well as Lion?

Looks like Snow Leopard doesn't set any attributes that contain the PID. :-(
Comment 6 Adam Roben (:aroben) 2011-12-08 08:30:10 PST 
Thanks for pointing that out, Eric. Bug 74094 contains a fix.