[chromium] Don't crash if tile upload happens without painting first
Created attachment 118084 [details] Patch
See: http://code.google.com/p/chromium/issues/detail?id=105569 I think this crash is caused by a paint/upload mismatch. A layer isn't painted but is uploaded from, so its tiler isn't created. I'm not totally sure where this is happening, but that seems like a likely culprit. The proper fix is the ForEachCompositorResource functor iteration from https://bugs.webkit.org/show_bug.cgi?id=72752, but I want something small that can be backported to m17.
Looks good to me. Any idea how we end up calling updateCompositorResources() without prepareToUpdate first?
(In reply to comment #3) > Looks good to me. Any idea how we end up calling updateCompositorResources() without prepareToUpdate first? I'm not totally sure, but there's two totally different code paths, so it seemed really plausible. Actually, ImageLayerChromium::paintContentsIfDirty has an early out before prepareToUpdate if the visible rect is empty. That would do it.
Created attachment 118090 [details] Fix ImageLayerChromium to not do this
Comment on attachment 118090 [details] Fix ImageLayerChromium to not do this This looks safe
Comment on attachment 118090 [details] Fix ImageLayerChromium to not do this Clearing flags on attachment: 118090 Committed r102180: <http://trac.webkit.org/changeset/102180>
All reviewed patches have been landed. Closing bug.