Bug 73930 - Web Inspector: introduce a memory agent stub.
Summary: Web Inspector: introduce a memory agent stub.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-06 10:05 PST by Pavel Feldman
Modified: 2011-12-06 15:49 PST (History)
14 users (show)

See Also:


Attachments
Patch (19.67 KB, patch)
2011-12-06 10:35 PST, Pavel Feldman
no flags Details | Formatted Diff | Diff
Patch (19.67 KB, patch)
2011-12-06 10:41 PST, Pavel Feldman
no flags Details | Formatted Diff | Diff
[Patch] with renamed method and a JSC bug reference. (19.76 KB, patch)
2011-12-06 11:06 PST, Pavel Feldman
timothy: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-12-06 10:05:39 PST
We'd like to experiment with the memory stats and hence need a nice home for that. Adding this undocumented agent / domain for now.
Comment 1 Pavel Feldman 2011-12-06 10:35:04 PST
Created attachment 118068 [details]
Patch
Comment 2 Pavel Feldman 2011-12-06 10:41:17 PST
Created attachment 118069 [details]
Patch
Comment 3 Timothy Hatcher 2011-12-06 10:42:40 PST
Comment on attachment 118069 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=118069&action=review

> Source/WebCore/bindings/js/ScriptProfiler.h:61
> +    static unsigned nodeCount() { return 0; }

Where is the JSC implementation or the bug? Please add a FIXME to the code where JSC just returns 0.
Comment 4 Timothy Hatcher 2011-12-06 10:44:11 PST
Also, what does "node" mean in this? DOM node or some JS memory node/cell?
Comment 5 Pavel Feldman 2011-12-06 11:06:08 PST
Created attachment 118073 [details]
[Patch] with renamed method and a JSC bug reference.
Comment 6 Timothy Hatcher 2011-12-06 11:10:13 PST
Comment on attachment 118073 [details]
[Patch] with renamed method and a JSC bug reference.

View in context: https://bugs.webkit.org/attachment.cgi?id=118073&action=review

> Source/WebCore/bindings/js/ScriptProfiler.h:61
> +    // FIXME: Implement this counter for JSC. See BUG73936 for more details.

"bug 73936" instead of "BUG73936" unless this is standard form in WebKit now.
Comment 7 WebKit Review Bot 2011-12-06 14:44:43 PST
Comment on attachment 118073 [details]
[Patch] with renamed method and a JSC bug reference.

Attachment 118073 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10742107
Comment 8 Pavel Feldman 2011-12-06 15:49:37 PST
Committed r102187: <http://trac.webkit.org/changeset/102187>