Bug 73928 - Put length in its own variable in KURL copyASCII
Summary: Put length in its own variable in KURL copyASCII
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on: 73794
Blocks:
  Show dependency tree / graph
 
Reported: 2011-12-06 09:51 PST by Benjamin Poulain
Modified: 2011-12-06 14:30 PST (History)
1 user (show)

See Also:

Attachments
Patch (1.28 KB, patch)
2011-12-06 09:57 PST, Benjamin Poulain 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2011-12-06 09:51:37 PST 
Darin is concerned for (size_t i = 0; i < string.length(); i++) my cause performance problem due to string.length().
Comment 1 Benjamin Poulain 2011-12-06 09:57:12 PST 
Created attachment 118063 [details]
Patch
Comment 2 Darin Adler 2011-12-06 10:13:55 PST 
Comment on attachment 118063 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=118063&action=review

> Source/WebCore/platform/KURL.cpp:267
> +        const size_t length = string.length();

Please remove the const (or you could make src also const and build a bicycle shed).
Comment 3 Benjamin Poulain 2011-12-06 14:05:11 PST 
Committed r102177: <http://trac.webkit.org/changeset/102177>