RESOLVED FIXED 73928
Put length in its own variable in KURL copyASCII 
https://bugs.webkit.org/show_bug.cgi?id=73928
Summary Put length in its own variable in KURL copyASCII
Benjamin Poulain
Reported 2011-12-06 09:51:37 PST
Darin is concerned for (size_t i = 0; i < string.length(); i++) my cause performance problem due to string.length().
Attachments
Patch (1.28 KB, patch)
2011-12-06 09:57 PST, Benjamin Poulain 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2011-12-06 09:57:12 PST
Created attachment 118063 [details] Patch
Darin Adler
Comment 2 2011-12-06 10:13:55 PST
Comment on attachment 118063 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=118063&action=review > Source/WebCore/platform/KURL.cpp:267 > + const size_t length = string.length(); Please remove the const (or you could make src also const and build a bicycle shed).
Benjamin Poulain
Comment 3 2011-12-06 14:05:11 PST
Committed r102177: <http://trac.webkit.org/changeset/102177>
Note You need to log in before you can comment on or make changes to this bug.