Bug 73923 - [Qt] QQuickWebView missing titleChanged signal tests
Summary: [Qt] QQuickWebView missing titleChanged signal tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-06 08:13 PST by Gopal Raghavan
Modified: 2011-12-11 19:25 PST (History)
2 users (show)

See Also:


Attachments
verify titleChanged signal (3.06 KB, patch)
2011-12-06 08:18 PST, Gopal Raghavan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gopal Raghavan 2011-12-06 08:13:28 PST
Signal tests are missing for titleChanged
Comment 1 Gopal Raghavan 2011-12-06 08:18:25 PST
Created attachment 118054 [details]
verify titleChanged signal

added qml tests to veriy titleChanged signal
Comment 2 Simon Hausmann 2011-12-07 00:22:17 PST
Comment on attachment 118054 [details]
verify titleChanged signal

View in context: https://bugs.webkit.org/attachment.cgi?id=118054&action=review

> Source/WebKit2/UIProcess/API/qt/tests/qmltests/common/test3.html:8
> +    var t = setTimeout("changeTitle('New Title')",3000);

If you want you can write this without an extra function I think, just setTimeout("document.title = 'New Title', 3000)
Comment 3 WebKit Review Bot 2011-12-11 19:25:37 PST
Comment on attachment 118054 [details]
verify titleChanged signal

Clearing flags on attachment: 118054

Committed r102554: <http://trac.webkit.org/changeset/102554>
Comment 4 WebKit Review Bot 2011-12-11 19:25:41 PST
All reviewed patches have been landed.  Closing bug.