[qt][wk2] Tests of QQuickWebView assert in debug builds when destroying QQuickWebViewPrivate

[Michael Brüning]

The assert happens because the destructor of QQuickWebViewPrivate destroys the interaction engine, which in turn emits a signal that is handled by QQuickWebViewPrivate.

[Michael Brüning]

Created attachment 118028 [details]
Patch to fix assertion.

[Kenneth Rohde Christiansen]

Comment on attachment 118028 [details]
Patch to fix assertion.

View in context: https://bugs.webkit.org/attachment.cgi?id=118028&action=review

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:79
> +{
> +    if (interactionEngine)
> +        interactionEngine->blockSignals(true);
> +}

why not disconnect all signals?

[Michael Brüning]

Created attachment 118035 [details]
Updated patch using disconnect instead of blockSignals

Update according to Kenneth's comment.

[Michael Brüning]

Comment on attachment 118035 [details]
Updated patch using disconnect instead of blockSignals

Updating flags

[Kenneth Rohde Christiansen]

Comment on attachment 118035 [details]
Updated patch using disconnect instead of blockSignals

View in context: https://bugs.webkit.org/attachment.cgi?id=118035&action=review

> Source/WebKit2/ChangeLog:8
> +        * UIProcess/API/qt/qquickwebview.cpp: Block signals from QtViewportInteractionEngine in 

diconnect

[Michael Brüning]

Created attachment 118041 [details]
Patch with fixed ChangeLog and commit message.

Fixed the ChangeLog and commit message.

[WebKit Review Bot]

Comment on attachment 118041 [details]
Patch with fixed ChangeLog and commit message.

Clearing flags on attachment: 118041

Committed r102142: <http://trac.webkit.org/changeset/102142>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.