Bug 73906 - Web Inspector: Multiple VMs: make ScriptArguments an interface.
Summary: Web Inspector: Multiple VMs: make ScriptArguments an interface.
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-06 04:08 PST by Pavel Podivilov
Modified: 2014-08-03 18:34 PDT (History)
2 users (show)

See Also:

Attachments
Patch. (13.92 KB, patch)
2011-12-06 04:10 PST, Pavel Podivilov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2011-12-06 04:08:30 PST 
Make ScriptArguments an interface so inspector console's clients are not limited to JavaScript.
Comment 1 Pavel Podivilov 2011-12-06 04:10:01 PST 
Created attachment 118021 [details]
Patch.
Comment 2 Eric Seidel (no email) 2011-12-06 12:24:01 PST 
Comment on attachment 118021 [details]
Patch.

All of these patches has the same potential problem: You're making possibly hot classes virtual.  In order for any of these patches to be reviewed for real, you would need to provide performance numbers that show that you've not regessed v8/jsc performance on some common benchmark (v8 or sunspider for example).