Bug 73899 - [V8] Multiple VMs: refactor SerializedScriptValue.
Summary: [V8] Multiple VMs: refactor SerializedScriptValue.
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-06 02:56 PST by Pavel Podivilov
Modified: 2014-12-16 00:48 PST (History)
1 user (show)

See Also:

Attachments
[DRAFT] (50.42 KB, patch)
2011-12-06 02:59 PST, Pavel Podivilov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2011-12-06 02:56:56 PST 
Extract v8 specific object traverse/construct to dedicated classes.
Comment 1 Pavel Podivilov 2011-12-06 02:59:09 PST 
Created attachment 118014 [details]
[DRAFT]
Comment 2 Eric Seidel (no email) 2011-12-06 12:20:00 PST 
Comment on attachment 118014 [details]
[DRAFT]

View in context: https://bugs.webkit.org/attachment.cgi?id=118014&action=review

> Source/WebCore/bindings/v8/SerializedScriptValue.cpp:1437
> +    bool readImageData(ScriptValueDeserializer& deserializer)

I cant think of any time in WebKit that we pass around a non-pod object by reference.  I guess RefPtr<>, but that's a template.  Although I suspect the compiler might do the right thing with virtual disapatch, since & isn't that different from *, I doubt this is kosher.
Comment 3 Brian Burg 2014-12-16 00:48:13 PST 
Closing some V8-related work items.