RESOLVED FIXED73890
Simplify KURL's checkEncodedString() 
https://bugs.webkit.org/show_bug.cgi?id=73890
Summary Simplify KURL's checkEncodedString()
Benjamin Poulain
Reported 2011-12-05 23:11:44 PST
Simplify KURL's checkEncodedString()
Attachments
Patch (1.67 KB, patch)
2011-12-05 23:36 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (1.47 KB, patch)
2011-12-06 16:15 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2011-12-05 23:36:01 PST
Created attachment 117997 [details] Patch
Benjamin Poulain
Comment 2 2011-12-05 23:42:45 PST
Comment on attachment 117997 [details] Patch Thanks
WebKit Review Bot
Comment 3 2011-12-06 05:05:01 PST
Comment on attachment 117997 [details] Patch Clearing flags on attachment: 117997 Committed r102123: <http://trac.webkit.org/changeset/102123>
WebKit Review Bot
Comment 4 2011-12-06 05:05:05 PST
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 5 2011-12-06 05:43:59 PST
It made all tests fail in debug mode. (GTK and Qt too) ASSERTION FAILED: !url.isEmpty() || isSchemeFirstChar(url[0]) ../../../../Source/WebCore/platform/KURL.cpp(300) : void WebCore::checkEncodedString(const WTF::String&) Could you guys fix it as soon as possible?
Andreas Kling
Comment 6 2011-12-06 06:02:27 PST
Assertion fixed with <http://trac.webkit.org/changeset/102128>
Benjamin Poulain
Comment 7 2011-12-06 09:31:31 PST
Thanks Andreas and Ossy. I was a bit too fast on that one...
Darin Adler
Comment 8 2011-12-06 09:56:17 PST
Comment on attachment 117997 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117997&action=review > Source/WebCore/platform/KURL.cpp:300 > + UNUSED_PARAM(url); > + ASSERT(url.containsOnlyASCII()); > + ASSERT(!url.isEmpty() || isSchemeFirstChar(url[0])); This should use ASSERT_UNUSED instead of a separate UNUSED_PARAM. In the future, UNUSED_PARAM will be changed to warn if the parameter is used, so we don’t want to compile it in, in any cases where the parameter is used.
Benjamin Poulain
Comment 9 2011-12-06 10:02:02 PST
(In reply to comment #8) > In the future, UNUSED_PARAM will be changed to warn if the parameter is used, so we don’t want to compile it in, in any cases where the parameter is used. I did not know that is the plan. I will update then.
Benjamin Poulain
Comment 10 2011-12-06 16:15:51 PST
Reopening to attach new patch.
Benjamin Poulain
Comment 11 2011-12-06 16:15:53 PST
Created attachment 118135 [details] Patch
WebKit Review Bot
Comment 12 2011-12-06 20:24:58 PST
Comment on attachment 118135 [details] Patch Clearing flags on attachment: 118135 Committed r102214: <http://trac.webkit.org/changeset/102214>
WebKit Review Bot
Comment 13 2011-12-06 20:25:03 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.