RESOLVED FIXED 73878
webkit.py: Really fix the printing of StringImpl now that 8 bit strings are present 
https://bugs.webkit.org/show_bug.cgi?id=73878
Summary webkit.py: Really fix the printing of StringImpl now that 8 bit strings are p...
Raphael Kubo da Costa (:rakuco)
Reported 2011-12-05 16:48:53 PST
r98624 turned StringImpl::m_data into StringImpl::{m_data8,m_data16}. r98785 made webkit.py always use m_data16, which does not work when the string is an 8-bit string (such as KURL::string()). I was not able to directly call StringImpl::is8Bit() in the Python code, so I just reproduced the implementation there.
Attachments
Patch (2.82 KB, patch)
2011-12-05 16:54 PST, Raphael Kubo da Costa (:rakuco) 		tony: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1 2011-12-05 16:54:00 PST
Created attachment 117956 [details] Patch
Tony Chang
Comment 2 2011-12-05 17:04:50 PST
Comment on attachment 117956 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117956&action=review > Tools/gdb/webkit.py:112 > + return self.val['m_impl']['m_ptr']['m_hashAndFlags'] & \ > + self.val['m_impl']['m_ptr']['s_hashFlag8BitBuffer'] The line wrapping is wrong (incorrect indention), but I would either just make this a single line. > Tools/gdb/webkit.py:136 > + return self.val['m_impl']['m_ptr']['m_hashAndFlags'] & \ > + self.val['m_impl']['m_ptr']['s_hashFlag8BitBuffer'] Ditto.
Raphael Kubo da Costa (:rakuco)
Comment 3 2011-12-05 18:09:20 PST
Committed r102083: <http://trac.webkit.org/changeset/102083>
Note You need to log in before you can comment on or make changes to this bug.