Bug 73871 - Create StringImpl::empty() as an 8 bit string
Summary: Create StringImpl::empty() as an 8 bit string
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks: 73236
  Show dependency treegraph
 
Reported: 2011-12-05 15:38 PST by Michael Saboff
Modified: 2011-12-06 09:21 PST (History)
1 user (show)

See Also:


Attachments
Patch (1.45 KB, patch)
2011-12-05 17:50 PST, Michael Saboff
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2011-12-05 15:38:06 PST
The zero length empty string returned by the static method StringImpl ::empty() should be created as an 8 bit string.

This will help performance when concatenated with other strings.
Comment 1 Michael Saboff 2011-12-05 17:50:30 PST
Created attachment 117968 [details]
Patch

This patch provides no performance benefit by itself, but allows for future changes that concat null strings to use an 8 bit path.
Comment 2 Michael Saboff 2011-12-05 18:07:02 PST
Committed r102082: <http://trac.webkit.org/changeset/102082>
Comment 3 Darin Adler 2011-12-06 09:21:01 PST
Comment on attachment 117968 [details]
Patch

Why?
Comment 4 Darin Adler 2011-12-06 09:21:32 PST
(In reply to comment #3)
> Why?

Oh, I see now. The rationale is in the bug, but not the patch. Next time please put it in the patch.