Bug 73868 – REGRESSION (r95249): Right side is truncated when printing

• Status: RESOLVED
• Resolution: FIXED
• Component: Printing

[Alexey Proskuryakov]

Right border is truncated when printing from Safari. I could reproduce this with apple.com and yahoo.com, so probably affects most/all pages.

Steps to reproduce:
1. Open http://www.yahoo.com
2. Cmd+P to open print preview dialog.

Results: right side of the page is truncated in preview dialog.

<rdar://problem/10388115>

[Kentaro Hara]

I'll take a look at it.

[Kentaro Hara]

Created attachment 118027 [details]
A simplified test case

When the attached html is printed, its right side is truncated.

[Kentaro Hara]

Created attachment 118029 [details]
WIP patch

[Kentaro Hara]

ap, hyatt: I uploaded a patch but I am not sure how I can write a test for the patch.

We need to test if the right sides of all lines in width-overflow.html are printed without being truncated, but how can we know if the right side is truncated or not? While layoutTestController.setPrinting() tells us the position of a bottom border of a page, it does not tell us the position of a right border (as you can see in width-overflow-expected.png). Any idea?

[Kentaro Hara]

(In reply to comment #4)
> ap, hyatt: I uploaded a patch but I am not sure how I can write a test for the patch.
> 
> We need to test if the right sides of all lines in width-overflow.html are printed without being truncated, but how can we know if the right side is truncated or not? While layoutTestController.setPrinting() tells us the position of a bottom border of a page, it does not tell us the position of a right border (as you can see in width-overflow-expected.png). Any idea?

Solved. I found that the right edge of the result of setPrinting() is the right border of the page:-)

[Kentaro Hara]

Created attachment 118178 [details]
patch for review

[Kentaro Hara]

ap, hyatt: Here are the setPrinting() results with/without my patch.

Without my patch: http://haraken.info/a/width-overflow-expected-before.png
With my patch: http://haraken.info/a/width-overflow-expected-after.png

[WebKit Review Bot]

Comment on attachment 118178 [details]
patch for review

Clearing flags on attachment: 118178

Committed r102281: <http://trac.webkit.org/changeset/102281>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.