Bug 73867 - V8RecursionScope should call didLeaveScriptContext when recursionLevel reaches zero
Summary: V8RecursionScope should call didLeaveScriptContext when recursionLevel reache...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Klein
URL:
Keywords:
Depends on:
Blocks: 73492
  Show dependency treegraph
 
Reported: 2011-12-05 14:32 PST by Adam Klein
Modified: 2011-12-05 16:33 PST (History)
4 users (show)

See Also:


Attachments
Patch (14.15 KB, patch)
2011-12-05 14:37 PST, Adam Klein
no flags Details | Formatted Diff | Diff
Patch for landing (14.00 KB, patch)
2011-12-05 14:55 PST, Adam Klein
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Klein 2011-12-05 14:32:38 PST
V8RecursionScope should call didLeaveScriptContext when recursionLevel reaches zero
Comment 1 Adam Klein 2011-12-05 14:37:02 PST
Created attachment 117939 [details]
Patch
Comment 2 Adam Barth 2011-12-05 14:40:06 PST
Comment on attachment 117939 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117939&action=review

> Source/WebCore/bindings/v8/V8RecursionScope.h:34
> +#if ENABLE(MUTATION_OBSERVERS)

Presumably this shouldn't be conditional on MUTATION_OBSERVERS, right?
Comment 3 Adam Klein 2011-12-05 14:54:47 PST
Comment on attachment 117939 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117939&action=review

>> Source/WebCore/bindings/v8/V8RecursionScope.h:34
>> +#if ENABLE(MUTATION_OBSERVERS)
> 
> Presumably this shouldn't be conditional on MUTATION_OBSERVERS, right?

Heh, good catch, I picked a bad file to use as a template...Removed.
Comment 4 Adam Klein 2011-12-05 14:55:19 PST
Created attachment 117943 [details]
Patch for landing
Comment 5 Adam Klein 2011-12-05 16:33:36 PST
Committed r102067: <http://trac.webkit.org/changeset/102067>