RESOLVED FIXED 73854
small refactor of RenderFlexibleBox 
https://bugs.webkit.org/show_bug.cgi?id=73854
Summary small refactor of RenderFlexibleBox
Tony Chang
Reported 2011-12-05 12:32:25 PST
small refactor of RenderFlexibleBox
Attachments
Patch (5.73 KB, patch)
2011-12-05 12:34 PST, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.71 KB, patch)
2011-12-05 13:08 PST, Tony Chang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2011-12-05 12:34:25 PST
Created attachment 117918 [details] Patch
Tony Chang
Comment 2 2011-12-05 12:35:07 PST
Easy review. Makes the variable names more like the names in RenderFlexibleBox::layoutColumnReverse.
Darin Adler
Comment 3 2011-12-05 12:36:14 PST
Comment on attachment 117918 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117918&action=review > Source/WebCore/rendering/RenderFlexibleBox.cpp:627 > + IntPoint childLocation(shouldFlipMainAxis ? totalMainExtent - mainAxisOffset - childMainExtent : mainAxisOffset, > + crossAxisOffset + flowAwareMarginBeforeForChild(child)); WebKit formatting rules forbid this kind of lining up since it’s not renaming-infriendly.
Tony Chang
Comment 4 2011-12-05 13:08:29 PST
Created attachment 117928 [details] Patch for landing
WebKit Review Bot
Comment 5 2011-12-05 20:59:27 PST
Comment on attachment 117928 [details] Patch for landing Clearing flags on attachment: 117928 Committed r102090: <http://trac.webkit.org/changeset/102090>
WebKit Review Bot
Comment 6 2011-12-05 20:59:31 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.