Bug 73854 - small refactor of RenderFlexibleBox
Summary: small refactor of RenderFlexibleBox
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-05 12:32 PST by Tony Chang
Modified: 2011-12-05 20:59 PST (History)
2 users (show)

See Also:


Attachments
Patch (5.73 KB, patch)
2011-12-05 12:34 PST, Tony Chang
no flags Details | Formatted Diff | Diff
Patch for landing (5.71 KB, patch)
2011-12-05 13:08 PST, Tony Chang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2011-12-05 12:32:25 PST
small refactor of RenderFlexibleBox
Comment 1 Tony Chang 2011-12-05 12:34:25 PST
Created attachment 117918 [details]
Patch
Comment 2 Tony Chang 2011-12-05 12:35:07 PST
Easy review.  Makes the variable names more like the names in RenderFlexibleBox::layoutColumnReverse.
Comment 3 Darin Adler 2011-12-05 12:36:14 PST
Comment on attachment 117918 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117918&action=review

> Source/WebCore/rendering/RenderFlexibleBox.cpp:627
> +        IntPoint childLocation(shouldFlipMainAxis ? totalMainExtent - mainAxisOffset - childMainExtent : mainAxisOffset,
> +                               crossAxisOffset + flowAwareMarginBeforeForChild(child));

WebKit formatting rules forbid this kind of lining up since it’s not renaming-infriendly.
Comment 4 Tony Chang 2011-12-05 13:08:29 PST
Created attachment 117928 [details]
Patch for landing
Comment 5 WebKit Review Bot 2011-12-05 20:59:27 PST
Comment on attachment 117928 [details]
Patch for landing

Clearing flags on attachment: 117928

Committed r102090: <http://trac.webkit.org/changeset/102090>
Comment 6 WebKit Review Bot 2011-12-05 20:59:31 PST
All reviewed patches have been landed.  Closing bug.