Bug 73845 – [Chromium] Remove no-longer-used forwarding headers in the WebKit API

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adam Barth]

[Chromium] Remove no-longer-used forwarding headers in the WebKit API

[Adam Barth]

Created attachment 117901 [details]
Patch

[Adam Barth]

Comment on attachment 117901 [details]
Patch

Oops.  Actually that patch has one cheat still in it.

[Adam Barth]

Created attachment 117902 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail] before submitting because this patch contains changes to the Chromium public API.

[James Robinson]

Comment on attachment 117902 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117902&action=review

> Source/WebKit/chromium/WebKit.gyp:279
> +                'public/android/WebInputEventFactory.h',

it looks like this is re-sorted in a case-sensitive way. are we supposed to do sorts ignoring case?

> Source/WebKit/chromium/src/AssociatedURLLoader.cpp:48
>  #include "WebFrameImpl.h"
> -#include "WebHTTPHeaderVisitor.h"
> +#include "platform/WebHTTPHeaderVisitor.h"
>  #include "WebKit.h"
> -#include "WebKitPlatformSupport.h"
> -#include "WebURLError.h"
> -#include "WebURLLoaderClient.h"
> -#include "WebURLRequest.h"
> +#include "platform/WebKitPlatformSupport.h"
> +#include "platform/WebURLError.h"
> +#include "platform/WebURLLoaderClient.h"
> +#include "platform/WebURLRequest.h"
>  #include "WrappedResourceRequest.h"

i think you need to resort these headers or the style bot will yell at you, won't it?

[Adam Barth]

(In reply to comment #5)
> (From update of attachment 117902 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=117902&action=review
> 
> > Source/WebKit/chromium/WebKit.gyp:279
> > +                'public/android/WebInputEventFactory.h',
> 
> it looks like this is re-sorted in a case-sensitive way. are we supposed to do sorts ignoring case?

WebKit uses case-sensitive sorting.

> > Source/WebKit/chromium/src/AssociatedURLLoader.cpp:48
> >  #include "WebFrameImpl.h"
> > -#include "WebHTTPHeaderVisitor.h"
> > +#include "platform/WebHTTPHeaderVisitor.h"
> >  #include "WebKit.h"
> > -#include "WebKitPlatformSupport.h"
> > -#include "WebURLError.h"
> > -#include "WebURLLoaderClient.h"
> > -#include "WebURLRequest.h"
> > +#include "platform/WebKitPlatformSupport.h"
> > +#include "platform/WebURLError.h"
> > +#include "platform/WebURLLoaderClient.h"
> > +#include "platform/WebURLRequest.h"
> >  #include "WrappedResourceRequest.h"
> 
> i think you need to resort these headers or the style bot will yell at you, won't it?

Done.  I'm not sure why check-webkit-style didn't complain.

[Adam Barth]

I sorted a bunch of these includes, but ran out of steam somewhere around BlobRegistry.

[Adam Barth]

Created attachment 117905 [details]
Patch

[Adam Barth]

Committed r102044: <http://trac.webkit.org/changeset/102044>