Bug 73841 - On Windows, filenames not properly preserved when copied into a file list exposed by Event.dataTransfer
Summary: On Windows, filenames not properly preserved when copied into a file list exp...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Steve Falkenburg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-05 10:32 PST by Steve Falkenburg
Modified: 2011-12-05 10:47 PST (History)
0 users

See Also:

Attachments
Patch (1.38 KB, patch)
2011-12-05 10:33 PST, Steve Falkenburg 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Falkenburg 2011-12-05 10:32:01 PST 
On Windows, filenames not properly preserved when copied into a file list exposed by Event.dataTransfer
Comment 1 Steve Falkenburg 2011-12-05 10:33:03 PST 
Created attachment 117896 [details]
Patch
Comment 2 Adam Roben (:aroben) 2011-12-05 10:39:53 PST 
Comment on attachment 117896 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117896&action=review

> Source/WebCore/ChangeLog:9
> +        No new tests. (OOPS!)

You should mention why this is.

> Source/WebCore/platform/win/ClipboardWin.cpp:575
> -        files->append(File::create((*it).characters()));
> +        files->append(File::create(*it));

It would be nice to explain in your ChangeLog why this fixes things. It took me a while to realize the problem must have been due to characters() not being null-terminated.
Comment 3 Steve Falkenburg 2011-12-05 10:47:04 PST 
Committed r102016: <http://trac.webkit.org/changeset/102016>