The searching mechanism built into WK does not search within frames and does not find frames when searching just for frames
Created attachment 117888 [details] patch
http://trac.webkit.org/changeset/102049
It seems like the test added by this patch is very crashy (~30%): http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=platform%2Fmac%2Faccessibility%2Fsearch-with-frames.html&group=%40ToT%20-%20webkit.org
(In reply to comment #3) > It seems like the test added by this patch is very crashy (~30%): > > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=platform%2Fmac%2Faccessibility%2Fsearch-with-frames.html&group=%40ToT%20-%20webkit.org can we get a crash log. this webpage is inscrutable
(In reply to comment #4) > (In reply to comment #3) > > It seems like the test added by this patch is very crashy (~30%): > > > > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=platform%2Fmac%2Faccessibility%2Fsearch-with-frames.html&group=%40ToT%20-%20webkit.org > > can we get a crash log. this webpage is inscrutable http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r102242%20(35272)/platform/mac/accessibility/search-with-frames-crash-log.txt Unfortunately the crash log isn't helpful :( Hopefully you can reproduce this crash locally.
(In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > It seems like the test added by this patch is very crashy (~30%): > > > > > > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=platform%2Fmac%2Faccessibility%2Fsearch-with-frames.html&group=%40ToT%20-%20webkit.org > > > > can we get a crash log. this webpage is inscrutable > > http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r102242%20(35272)/platform/mac/accessibility/search-with-frames-crash-log.txt > > Unfortunately the crash log isn't helpful :( Hopefully you can reproduce this crash locally. Why is this crash log not useful? What leads you to believe it's this test causing the issues?
(In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > (In reply to comment #3) > > > > It seems like the test added by this patch is very crashy (~30%): > > > > > > > > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=platform%2Fmac%2Faccessibility%2Fsearch-with-frames.html&group=%40ToT%20-%20webkit.org > > > > > > can we get a crash log. this webpage is inscrutable > > > > http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r102242%20(35272)/platform/mac/accessibility/search-with-frames-crash-log.txt > > > > Unfortunately the crash log isn't helpful :( Hopefully you can reproduce this crash locally. > > Why is this crash log not useful? > > What leads you to believe it's this test causing the issues? Rather, I mean, why do you think this is not a real bug that needs to be fixed independent of this test
(In reply to comment #7) > (In reply to comment #6) > > Why is this crash log not useful? > > > > What leads you to believe it's this test causing the issues? > > Rather, I mean, why do you think this is not a real bug that needs to be fixed independent of this test Oh, I'm not saying that we should fix the test. We should fix WebKit not to crash.
(In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #6) > > > Why is this crash log not useful? > > > > > > What leads you to believe it's this test causing the issues? > > > > Rather, I mean, why do you think this is not a real bug that needs to be fixed independent of this test > > Oh, I'm not saying that we should fix the test. We should fix WebKit not to crash. Will see if i can repro... we should open a new bug... are all the crash logs the same or are they different?
(In reply to comment #9) > Will see if i can repro... we should open a new bug... > are all the crash logs the same or are they different? I haven't been able to figure that out. If you go to the flakiness dashboard, you can click on one of those orange bars, you can get to build result pages.
(In reply to comment #10) > (In reply to comment #9) > > Will see if i can repro... we should open a new bug... > > are all the crash logs the same or are they different? > > I haven't been able to figure that out. If you go to the flakiness dashboard, you can click on one of those orange bars, you can get to build result pages. We have a bug for this with a reasonable looking backtrace https://bugs.webkit.org/show_bug.cgi?id=74093