Bug 73824 - Rewrite action_derivedsourcesallinone.py in Perl
Summary: Rewrite action_derivedsourcesallinone.py in Perl
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 73394
  Show dependency tree / graph
 
Reported: 2011-12-05 04:43 PST by Kentaro Hara
Modified: 2011-12-05 22:22 PST (History)
3 users (show)

See Also:

Attachments
Patch (18.22 KB, patch)
2011-12-05 05:01 PST, Kentaro Hara 		abarth: review+
haraken: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2011-12-05 04:43:38 PST 
On Chromium/Windows build, 

- /usr/bin/perl generates "/cygdrive/c/home/..."-style paths when it applies Cwd::realpath() to file paths.
- /usr/bin/python can recognize "C:/cygwin/home/..."-style paths but cannot recognize "/cygdrive/c/home/..."-style paths.

This makes it difficult to read Perl's (i.e. generate-bindings.pl) output by Python (i.e. action_derivedsourcesallinone.py) (See comment #23 in bug 73394 for more details). 

The easy solution for this is to rewrite action_derivedsourcesallinone.py in Perl. In this way this path-style issue goes away, since /user/bin/perl can recognize (both "C:/cygwin/home/..."-style paths and) "/cygdrive/c/home/..."-style paths.
Comment 1 Kentaro Hara 2011-12-05 05:01:53 PST 
Created attachment 117868 [details]
Patch
Comment 2 Adam Barth 2011-12-05 10:56:59 PST 
Comment on attachment 117868 [details]
Patch

There might actually be a native GYP facility for doing this now, but this looks fine.
Comment 3 Adam Barth 2011-12-05 22:20:22 PST 
This is INVALID now, right?  Please reopen if I've misunderstood the discussion in the other bug.
Comment 4 Kentaro Hara 2011-12-05 22:22:26 PST 
(In reply to comment #3)
> This is INVALID now, right?  Please reopen if I've misunderstood the discussion in the other bug.

Right. Thanks. Depending on Tony's opinion, it may be re-opened though.