RESOLVED INVALID 73824
Rewrite action_derivedsourcesallinone.py in Perl 
https://bugs.webkit.org/show_bug.cgi?id=73824
Summary Rewrite action_derivedsourcesallinone.py in Perl
Kentaro Hara
Reported 2011-12-05 04:43:38 PST
On Chromium/Windows build, - /usr/bin/perl generates "/cygdrive/c/home/..."-style paths when it applies Cwd::realpath() to file paths. - /usr/bin/python can recognize "C:/cygwin/home/..."-style paths but cannot recognize "/cygdrive/c/home/..."-style paths. This makes it difficult to read Perl's (i.e. generate-bindings.pl) output by Python (i.e. action_derivedsourcesallinone.py) (See comment #23 in bug 73394 for more details). The easy solution for this is to rewrite action_derivedsourcesallinone.py in Perl. In this way this path-style issue goes away, since /user/bin/perl can recognize (both "C:/cygwin/home/..."-style paths and) "/cygdrive/c/home/..."-style paths.
Attachments
Patch (18.22 KB, patch)
2011-12-05 05:01 PST, Kentaro Hara 		abarth: review+
haraken: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2011-12-05 05:01:53 PST
Created attachment 117868 [details] Patch
Adam Barth
Comment 2 2011-12-05 10:56:59 PST
Comment on attachment 117868 [details] Patch There might actually be a native GYP facility for doing this now, but this looks fine.
Adam Barth
Comment 3 2011-12-05 22:20:22 PST
This is INVALID now, right? Please reopen if I've misunderstood the discussion in the other bug.
Kentaro Hara
Comment 4 2011-12-05 22:22:26 PST
(In reply to comment #3) > This is INVALID now, right? Please reopen if I've misunderstood the discussion in the other bug. Right. Thanks. Depending on Tony's opinion, it may be re-opened though.
Note You need to log in before you can comment on or make changes to this bug.