Changed the SecurityOrigin argument to a String in PeerConnectionHandler and associated files.
This is done for two reasons:
1) Using SecurityContext breaks the layering pattern
2) The textual representation is enough anyway.
Created attachment 117864 [details]
Please wait for approval from firstname.lastname@example.org before submitting because this patch contains changes to the Chromium public API.
Created attachment 126510 [details]
Is this something Adam recommended? Is the idea that "platform" level stuff should not depend on SecurityOrigin?
Generally, replacing SecurityOrigin with a String is seen as the wrong thing to do. I find it interesting that you are calling the result of SecurityOrigin::toString() a "username"... can you say more about what this string is meant to represent? Typically, security origins are URLs (but not always), so I'd like to better understand what it is for media streams.
How will the consumer of this string make use of this field? Are you saying that it will just be treated in opaque fashion? What is its purpose then?
It is partly a platform violation but the main reason is that we need it in string form only so I'm changing to to the correct type.
The URL is used in the ice negotiation as a little security.
Seems fine. What is the string called in the spec? As much as possible, we should try to reuse names from the spec in the implementation.
It's called username.
Quote: "The long-term username for the STUN or TURN server is the ASCII serialization of the entry script's origin;"
FYI I discussed with Harald who said that the username will have to be specified when creating the PeerConnection object instead of taking the SecurityOrigin in a future revision of the specification. Yet another reason to do this change now.
Comment on attachment 126510 [details]
Clearing flags on attachment: 126510
Committed r107861: <http://trac.webkit.org/changeset/107861>
All reviewed patches have been landed. Closing bug.