RESOLVED FIXED 73813
[Qt] Rename QQuickWebView::canStop property to just loading 
https://bugs.webkit.org/show_bug.cgi?id=73813
Summary [Qt] Rename QQuickWebView::canStop property to just loading
Simon Hausmann
Reported 2011-12-05 03:03:02 PST
See summary, I think "loading" is a better name than "canStop" Let the bike-shedding begin :)
Attachments
Patch (8.27 KB, patch)
2011-12-05 08:15 PST, Michael Brüning 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Brüning
Comment 1 2011-12-05 08:15:20 PST
Created attachment 117882 [details] Patch Proposed patch based on summary.
Jesus Sanchez-Palencia
Comment 2 2011-12-05 10:38:22 PST
Comment on attachment 117882 [details] Patch LGTM. Perhaps you forgot to ask for a proper review, Michael? Changing flags for the patch.
WebKit Review Bot
Comment 3 2011-12-05 11:25:21 PST
Comment on attachment 117882 [details] Patch Attachment 117882 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10689688 New failing tests: svg/custom/linking-uri-01-b.svg
Kenneth Rohde Christiansen
Comment 4 2011-12-05 12:17:12 PST
Comment on attachment 117882 [details] Patch This is all in wb2 so the chromium error must be due to flakiness
WebKit Review Bot
Comment 5 2011-12-05 13:16:17 PST
Comment on attachment 117882 [details] Patch Clearing flags on attachment: 117882 Committed r102035: <http://trac.webkit.org/changeset/102035>
WebKit Review Bot
Comment 6 2011-12-05 13:16:22 PST
All reviewed patches have been landed. Closing bug.
Simon Hausmann
Comment 7 2011-12-06 01:51:48 PST
I was serious about the bike-shedding. We should discuss the options here. It _may_ seem that loading is a better name, but there are also arguments against it. Tor Arne is looking into what we did in Grob and what fits best there. Michael not setting r? was intentional.
Jesus Sanchez-Palencia
Comment 8 2011-12-06 02:35:49 PST
(In reply to comment #7) > I was serious about the bike-shedding. We should discuss the options here. It _may_ seem that loading is a better name, but there are also arguments against it. Tor Arne is looking into what we did in Grob and what fits best there. > When I looked at the patch "loading" made way more sense than "canStop". Plus, I remember seeing "loading" as property on other mobile webview APIs before, perhaps on the iOS one, and that also motivated me. > Michael not setting r? was intentional. I'm truly sorry, Simon, I didn't realize it. It was a legitimate mistake. Whatever we decide here, I will make the needed changes.
Simon Hausmann
Comment 9 2012-02-20 02:57:53 PST
As part of the API review session at the meeting in Szeged we decided to keep "loading". See also bug #78820 for related changes.
Note You need to log in before you can comment on or make changes to this bug.