After http://trac.webkit.org/changeset/101975 fast/backgrounds/animated-gif-as-background.html = CRASH fast/images/dont-crash-with-null-gif-frames.html = CRASH (on 64-bit only) fast/images/gif-loop-count.html = CRASH
% pwd third_party/WebKit/Source/WebCore/platform/image-decoders/gif % ack m_data * GIFImageDecoder.cpp 87: reader.read((const unsigned char*)m_data->data(), m_data->size(), GIFFrameCountQuery, static_cast<unsigned>(-1)); 192: m_readOffset = m_data->size() - bytesLeft; 321: if (!m_reader->read((const unsigned char*)m_data->data() + m_readOffset, m_data->size() - m_readOffset, query, haltAtFrame) && isAllDataReceived())
Hence, m_data->size() is used in the GIF decoder.
Ignore me: m_data->size() is the decoder input data.
Created attachment 117947 [details] Patch
Comment on attachment 117947 [details] Patch Ok. Do you think this will fix the tests?
My belief is it won't fix them. I don't have a GTK setup to test locally, so I'm prepared to try this patch, and hence rule out whether the issue depends on the resize() or not.
Comment on attachment 117947 [details] Patch Clearing flags on attachment: 117947 Committed r102096: <http://trac.webkit.org/changeset/102096>
All reviewed patches have been landed. Closing bug.
belief is one thing, results are another. GTK Linux 32-bit Release @ r102096 http://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/19773 2011-12-05 22:39:23,028 7601 worker.py:186 DEBUG worker/0 fast/backgrounds/animated-gif-as-background.html passed 2011-12-05 22:41:49,861 7601 worker.py:186 DEBUG worker/0 fast/images/dont-crash-with-null-gif-frames.html passed 2011-12-05 22:41:50,508 7601 worker.py:186 DEBUG worker/0 fast/images/gif-loop-count.html passed GTK Linux 64-bit Release @ r102096 http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release/builds/14197 2011-12-05 22:26:17,985 7968 worker.py:186 DEBUG worker/17 fast/backgrounds/animated-gif-as-background.html passed 2011-12-05 22:26:26,587 7931 worker.py:186 DEBUG worker/5 fast/images/dont-crash-with-null-gif-frames.html passed 2011-12-05 22:26:27,177 7931 worker.py:186 DEBUG worker/5 fast/images/gif-loop-count.html passed GTK Linux 64-bit Debug @ r102096 http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug/builds/28212 2011-12-05 22:37:17,192 12694 worker.py:186 DEBUG worker/3 fast/backgrounds/animated-gif-as-background.html passed 2011-12-05 22:39:50,284 12685 worker.py:186 DEBUG worker/0 fast/images/dont-crash-with-null-gif-frames.html passed 2011-12-05 22:39:51,022 12685 worker.py:186 DEBUG worker/0 fast/images/gif-loop-count.html passed LGTM.