Bug 73806 - [Chromium] unknown characters symbol on \n in complex script text (RTL and LTR)
Summary: [Chromium] unknown characters symbol on \n in complex script text (RTL and LTR)
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kenichi Ishibashi
URL: http://crbug.com/105494
Depends on: 73991
  Show dependency treegraph
Reported: 2011-12-05 02:01 PST by Kenichi Ishibashi
Modified: 2011-12-07 02:13 PST (History)
5 users (show)

See Also:

Patch (5.25 KB, patch)
2011-12-05 18:00 PST, Kenichi Ishibashi
no flags Details | Formatted Diff | Diff
Patch for landing (5.14 KB, patch)
2011-12-06 15:59 PST, Kenichi Ishibashi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenichi Ishibashi 2011-12-05 02:01:48 PST
See http://crbug.com/105494 for details.

In UniscribeHelper::fillRuns(), successive SCRIPT_ITEMs that are tagged SCRIPT_TAG_UNKNOWN are merged to reduce script runs. However, it seems that we shouldn't merge SCRIPT_ITEMs when it contains non-printable characters.
Comment 1 Kenichi Ishibashi 2011-12-05 18:00:18 PST
Created attachment 117970 [details]
Comment 2 Tony Chang 2011-12-06 09:33:29 PST
Comment on attachment 117970 [details]

Seems fine to me.  Jungshik, do you want to review the code also?
Comment 3 Jungshik Shin 2011-12-06 13:31:22 PST
LG except that I like to add a LTR complex script case to the test. 

One taken from Chrome bug:   <p>.%0A&#x0915;</p>
Comment 4 Tony Chang 2011-12-06 13:57:39 PST
Also, we should just put the new test in LayoutTests/fast/text/international/ rather than making it Chromium specific.
Comment 5 Kenichi Ishibashi 2011-12-06 15:59:11 PST
Created attachment 118129 [details]
Patch for landing
Comment 6 Kenichi Ishibashi 2011-12-06 15:59:55 PST
(In reply to comment #5)
> Created an attachment (id=118129) [details]
> Patch for landing

Addressed comments. Thank you for review!
Comment 7 WebKit Review Bot 2011-12-06 16:38:51 PST
Comment on attachment 118129 [details]
Patch for landing

Clearing flags on attachment: 118129

Committed r102190: <http://trac.webkit.org/changeset/102190>
Comment 8 WebKit Review Bot 2011-12-06 16:38:56 PST
All reviewed patches have been landed.  Closing bug.