Bug 73795 - Remove methods declared but never implemented with GOOGLEURL
Summary: Remove methods declared but never implemented with GOOGLEURL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-04 20:29 PST by Benjamin Poulain
Modified: 2011-12-05 17:10 PST (History)
1 user (show)

See Also:


Attachments
Patch (1.34 KB, patch)
2011-12-04 20:29 PST, Benjamin Poulain
no flags Details | Formatted Diff | Diff
Patch (1.40 KB, patch)
2011-12-04 20:31 PST, Benjamin Poulain
no flags Details | Formatted Diff | Diff
Patch (1.45 KB, patch)
2011-12-04 20:40 PST, Benjamin Poulain
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2011-12-04 20:29:28 PST
Created attachment 117830 [details]
Patch

Reviewed by NOBODY (OOPS!).

* platform/KURL.h:
---
 2 files changed, 8 insertions(+), 3 deletions(-)
Comment 1 Benjamin Poulain 2011-12-04 20:31:48 PST
Created attachment 117831 [details]
Patch
Comment 2 WebKit Review Bot 2011-12-04 20:33:49 PST
Attachment 117831 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 1 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Benjamin Poulain 2011-12-04 20:39:55 PST
Why didn't webkit patch send the right diff? :(
Comment 4 Benjamin Poulain 2011-12-04 20:40:19 PST
Created attachment 117833 [details]
Patch
Comment 5 Benjamin Poulain 2011-12-05 17:10:41 PST
Committed r102073: <http://trac.webkit.org/changeset/102073>