Bug 73792 - Get rid of KURL::KURL(ParsedURLStringTag, const char*);
: Get rid of KURL::KURL(ParsedURLStringTag, const char*);
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: WebCore Misc.
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Benjamin Poulain
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-04 19:10 PST by Benjamin Poulain
Modified: 2011-12-05 17:51 PST (History)
6 users (show)

See Also:


Attachments
Patch (6.13 KB, patch)
2011-12-04 19:20 PST, Benjamin Poulain
no flags Details | Formatted Diff | Diff
Patch (7.51 KB, patch)
2011-12-04 20:24 PST, Benjamin Poulain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2011-12-04 19:10:15 PST
KURL::parse() takes a char* instead of the CharBuffer because of KURL::KURL(ParsedURLStringTag, const char*);

That constructor does not seem to be used by anything important. Let's remove it and see if the bots like that better.
Comment 1 Benjamin Poulain 2011-12-04 19:20:55 PST
Created attachment 117825 [details]
Patch
Comment 2 WebKit Review Bot 2011-12-04 20:13:40 PST
Comment on attachment 117825 [details]
Patch

Attachment 117825 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10734545
Comment 3 Benjamin Poulain 2011-12-04 20:23:12 PST
Ooops, forgot the GoogleURL implementation, fixing that... :)
Comment 4 Benjamin Poulain 2011-12-04 20:24:16 PST
Created attachment 117829 [details]
Patch
Comment 5 Andreas Kling 2011-12-04 21:10:25 PST
Comment on attachment 117829 [details]
Patch

Looks great!
Comment 6 Benjamin Poulain 2011-12-04 21:14:43 PST
Comment on attachment 117829 [details]
Patch

I'll land tomorrow so Darin and Adam also have a chance to look at the patch.
Comment 7 Adam Barth 2011-12-04 21:39:36 PST
Comment on attachment 117829 [details]
Patch

Nice.
Comment 8 WebKit Review Bot 2011-12-05 17:51:45 PST
Comment on attachment 117829 [details]
Patch

Clearing flags on attachment: 117829

Committed r102080: <http://trac.webkit.org/changeset/102080>
Comment 9 WebKit Review Bot 2011-12-05 17:51:50 PST
All reviewed patches have been landed.  Closing bug.