Bug 73780 - Convert JSClassRef to use HashMap<OwnPtr>
Summary: Convert JSClassRef to use HashMap<OwnPtr>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks: 73757
  Show dependency treegraph
 
Reported: 2011-12-04 14:26 PST by Darin Adler
Modified: 2013-05-07 08:57 PDT (History)
1 user (show)

See Also:


Attachments
Patch (13.46 KB, patch)
2011-12-04 14:31 PST, Darin Adler
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2011-12-04 14:26:29 PST
Convert JSClassRef to use HashMap<OwnPtr>
Comment 1 Darin Adler 2011-12-04 14:31:04 PST
Created attachment 117808 [details]
Patch
Comment 2 Andreas Kling 2011-12-04 18:49:08 PST
Comment on attachment 117808 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117808&action=review

> Source/JavaScriptCore/API/JSClassRef.cpp:82
>                  // Use a local variable here to sidestep an RVCT compiler bug.

Side-stepping RVCT bugs is not an issue anymore AFAIK.
Support for Symbian has been removed from WebKit trunk, and I believe it was the only user of RVCT.
(This comment repeated for each occurrence of that workaround.)
Comment 3 WebKit Review Bot 2011-12-05 16:17:53 PST
Comment on attachment 117808 [details]
Patch

Clearing flags on attachment: 117808

Committed r102065: <http://trac.webkit.org/changeset/102065>
Comment 4 WebKit Review Bot 2011-12-05 16:17:57 PST
All reviewed patches have been landed.  Closing bug.