Bug 73779 – Move code for connections to/from the UIProcess/WebProcess into WebConnection subclasses

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

Move code for connections to/from the UIProcess/WebProcess into WebConnection subclasses

[Sam Weinig]

Created attachment 117807 [details]
Patch

[Sam Weinig]

This is in preparation of exposing the connections as API objects.

[WebKit Review Bot]

Attachment 117807 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/WebProcess/WebProcess.h:40:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Comment on attachment 117807 [details]
Patch

Attachment 117807 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10727661

New failing tests:
svg/custom/linking-uri-01-b.svg

[Anders Carlsson]

Comment on attachment 117807 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117807&action=review

> Source/WebKit2/UIProcess/WebConnectionToWebProcess.cpp:97
> +    // This will invalidate the CoreIPC::Connection and the WebProcessProxy pointer
> +    // so we should be careful not to use them after this call.

Please clarify that it's the member variable that will be invalidated.

>> Source/WebKit2/WebProcess/WebProcess.h:40
>> +#include "WebConnectionToUIProcess.h"
> 
> Alphabetical sorting problem.  [build/include_order] [4]

Please fix this.

[Sam Weinig]

Committed r102014: <http://trac.webkit.org/changeset/102014>