Bug 73779 - Move code for connections to/from the UIProcess/WebProcess into WebConnection subclasses
Summary: Move code for connections to/from the UIProcess/WebProcess into WebConnection...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-04 14:18 PST by Sam Weinig
Modified: 2011-12-05 10:41 PST (History)
3 users (show)

See Also:


Attachments
Patch (51.55 KB, patch)
2011-12-04 14:23 PST, Sam Weinig
andersca: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2011-12-04 14:18:37 PST
Move code for connections to/from the UIProcess/WebProcess into WebConnection subclasses
Comment 1 Sam Weinig 2011-12-04 14:23:27 PST
Created attachment 117807 [details]
Patch
Comment 2 Sam Weinig 2011-12-04 14:24:27 PST
This is in preparation of exposing the connections as API objects.
Comment 3 WebKit Review Bot 2011-12-04 14:27:18 PST
Attachment 117807 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/WebProcess/WebProcess.h:40:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 WebKit Review Bot 2011-12-04 17:05:52 PST
Comment on attachment 117807 [details]
Patch

Attachment 117807 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10727661

New failing tests:
svg/custom/linking-uri-01-b.svg
Comment 5 Anders Carlsson 2011-12-05 10:34:08 PST
Comment on attachment 117807 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117807&action=review

> Source/WebKit2/UIProcess/WebConnectionToWebProcess.cpp:97
> +    // This will invalidate the CoreIPC::Connection and the WebProcessProxy pointer
> +    // so we should be careful not to use them after this call.

Please clarify that it's the member variable that will be invalidated.

>> Source/WebKit2/WebProcess/WebProcess.h:40
>> +#include "WebConnectionToUIProcess.h"
> 
> Alphabetical sorting problem.  [build/include_order] [4]

Please fix this.
Comment 6 Sam Weinig 2011-12-05 10:41:57 PST
Committed r102014: <http://trac.webkit.org/changeset/102014>