Patch incoming...
Created attachment 117795 [details] enable-fullscreen web-setting
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment on attachment 117795 [details] enable-fullscreen web-setting All of the recent additions to WebSettings have included a very simple update to the unit tests. Do you mind adding this?
Created attachment 117797 [details] enable-fullscreen web-setting
Comment on attachment 117797 [details] enable-fullscreen web-setting View in context: https://bugs.webkit.org/attachment.cgi?id=117797&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:741 > + * Whether to enable the Javascript Fullscreen API. Do you mind writing a small blurb about what the fullscreen API is and then also linking to the spec?
Committed r101962: <http://trac.webkit.org/changeset/101962>
(In reply to comment #5) > (From update of attachment 117797 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=117797&action=review > > > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:741 > > + * Whether to enable the Javascript Fullscreen API. > > Do you mind writing a small blurb about what the fullscreen API is and then also linking to the spec? I did so. Thanks for the review!