[chromium] Remove forwarding headers for WebLayer APIs
Created attachment 117729 [details] Patch
This can't land until http://codereview.chromium.org/8788008/ is landed, or it'll break the chromium compile. We do not have to wait for anything to roll into Source/WebKit/chromium/DEPS, just make sure it's committed.
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
LGTM FWIW
Comment on attachment 117729 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117729&action=review > Source/WebKit/chromium/src/WebLayerTreeView.cpp:32 > +#include "platform/WebLayer.h" The main question is whether we want to add platform to the include path. I think having the directory name here is helpful, but that's not precisely webkit style.
(In reply to comment #5) > (From update of attachment 117729 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=117729&action=review > > > Source/WebKit/chromium/src/WebLayerTreeView.cpp:32 > > +#include "platform/WebLayer.h" > > The main question is whether we want to add platform to the include path. I think having the directory name here is helpful, but that's not precisely webkit style. I really like the directory name too. I like it because it reminds you of the module you are depending on. WebKit uses this approach for including files from WTF, so it is not entirely foreign to WebKit.
(In reply to comment #6) > I really like the directory name too. I like it because it reminds you of the module you are depending on. WebKit uses this approach for including files from WTF, so it is not entirely foreign to WebKit. However, one thing bugs me a bit. If we expect to move WebKit/chromium/public/platform/ to Platform/chromium/public/ someday, then the "platform/foo" includes would all need to be fixed up. Don't care?
I kind of like that, actually - it'll be easier to find all the #includes across the codebase and make sure the move will behave as expected.
Committed r102019: <http://trac.webkit.org/changeset/102019>
Committed r102500: <http://trac.webkit.org/changeset/102500>