Bug 73725 - CSSStyleSheet: Parent rule can only ever be @import, enforce this at compile time.
Summary: CSSStyleSheet: Parent rule can only ever be @import, enforce this at compile ...
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
Depends on:
Reported: 2011-12-02 17:47 PST by Andreas Kling
Modified: 2011-12-03 19:51 PST (History)
6 users (show)

See Also:

Patch (9.16 KB, patch)
2011-12-02 18:01 PST, Andreas Kling
darin: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (9.87 KB, patch)
2011-12-03 17:32 PST, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-12-02 17:47:56 PST
Per CSSOM (and our implementation), a CSSStyleSheet's parent rule can only ever be a CSSImportRule. We should enforce this at compile time instead of allowing any CSSRule as parent.
Comment 1 Andreas Kling 2011-12-02 18:01:00 PST
Created attachment 117722 [details]
Comment 2 WebKit Review Bot 2011-12-02 18:42:52 PST
Comment on attachment 117722 [details]

Attachment 117722 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10725619
Comment 3 Andreas Kling 2011-12-03 17:32:43 PST
Created attachment 117778 [details]
Patch for landing

Same patch with CodeGeneratorV8.pm tweaked to include CSSImportRule.h for CSSStyleSheet and StyleSheet bindings.
Comment 4 Andreas Kling 2011-12-03 19:51:38 PST
Committed r101943: <http://trac.webkit.org/changeset/101943>