RESOLVED FIXED 73725
CSSStyleSheet: Parent rule can only ever be @import, enforce this at compile time.
https://bugs.webkit.org/show_bug.cgi?id=73725
Summary CSSStyleSheet: Parent rule can only ever be @import, enforce this at compile ...
Andreas Kling
Reported 2011-12-02 17:47:56 PST
Per CSSOM (and our implementation), a CSSStyleSheet's parent rule can only ever be a CSSImportRule. We should enforce this at compile time instead of allowing any CSSRule as parent.
Attachments
Patch (9.16 KB, patch)
2011-12-02 18:01 PST, Andreas Kling
darin: review+
webkit.review.bot: commit-queue-
Patch for landing (9.87 KB, patch)
2011-12-03 17:32 PST, Andreas Kling
no flags
Andreas Kling
Comment 1 2011-12-02 18:01:00 PST
WebKit Review Bot
Comment 2 2011-12-02 18:42:52 PST
Comment on attachment 117722 [details] Patch Attachment 117722 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10725619
Andreas Kling
Comment 3 2011-12-03 17:32:43 PST
Created attachment 117778 [details] Patch for landing Same patch with CodeGeneratorV8.pm tweaked to include CSSImportRule.h for CSSStyleSheet and StyleSheet bindings.
Andreas Kling
Comment 4 2011-12-03 19:51:38 PST
Note You need to log in before you can comment on or make changes to this bug.