WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
73724
Upstream the Cursor implementation of iOS
https://bugs.webkit.org/show_bug.cgi?id=73724
Summary
Upstream the Cursor implementation of iOS
Benjamin Poulain
Reported
2011-12-02 17:40:00 PST
Created
attachment 117717
[details]
Patch Reviewed by NOBODY (OOPS!). iOS does not need to support the Cursor of WebKit. For compatibility, Cursor is implemented as an empty class on the platform. * Configurations/WebCore.xcconfig: * WebCore.xcodeproj/project.pbxproj: * platform/Cursor.h: (WebCore::Cursor::Cursor): * platform/ios/CursorIOS.cpp: Added. (WebCore::cursor): (WebCore::pointerCursor): (WebCore::crossCursor): (WebCore::handCursor): (WebCore::moveCursor): (WebCore::iBeamCursor): (WebCore::waitCursor): (WebCore::helpCursor): (WebCore::eastResizeCursor): (WebCore::northResizeCursor): (WebCore::northEastResizeCursor): (WebCore::northWestResizeCursor): (WebCore::southResizeCursor): (WebCore::southEastResizeCursor): (WebCore::southWestResizeCursor): (WebCore::westResizeCursor): (WebCore::northSouthResizeCursor): (WebCore::eastWestResizeCursor): (WebCore::northEastSouthWestResizeCursor): (WebCore::northWestSouthEastResizeCursor): (WebCore::columnResizeCursor): (WebCore::rowResizeCursor): (WebCore::middlePanningCursor): (WebCore::eastPanningCursor): (WebCore::northPanningCursor): (WebCore::northEastPanningCursor): (WebCore::northWestPanningCursor): (WebCore::southPanningCursor): (WebCore::southEastPanningCursor): (WebCore::southWestPanningCursor): (WebCore::westPanningCursor): (WebCore::verticalTextCursor): (WebCore::cellCursor): (WebCore::contextMenuCursor): (WebCore::noDropCursor): (WebCore::notAllowedCursor): (WebCore::progressCursor): (WebCore::aliasCursor): (WebCore::zoomInCursor): (WebCore::zoomOutCursor): (WebCore::copyCursor): (WebCore::noneCursor): (WebCore::grabCursor): (WebCore::grabbingCursor): (WebCore::determineHotSpot): --- 5 files changed, 328 insertions(+), 3 deletions(-)
Attachments
Patch
(12.99 KB, patch)
2011-12-02 17:40 PST
,
Benjamin Poulain
ddkilzer
: review+
ddkilzer
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
WebKit Review Bot
Comment 1
2011-12-02 17:44:11 PST
Attachment 117717
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
David Kilzer (:ddkilzer)
Comment 2
2011-12-04 04:23:00 PST
Comment on
attachment 117717
[details]
Patch r=me as long as you add the bug number to the ChangeLog. May also be worth filing a bug about a shared NullCursor implementation since the WinCE port does something similar to this.
Benjamin Poulain
Comment 3
2011-12-05 22:31:59 PST
Committed
r102097
: <
http://trac.webkit.org/changeset/102097
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug