Bug 73724 - Upstream the Cursor implementation of iOS
Summary: Upstream the Cursor implementation of iOS
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
Depends on:
Reported: 2011-12-02 17:40 PST by Benjamin Poulain
Modified: 2011-12-05 22:31 PST (History)
3 users (show)

See Also:

Patch (12.99 KB, patch)
2011-12-02 17:40 PST, Benjamin Poulain
ddkilzer: review+
ddkilzer: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2011-12-02 17:40:00 PST
Created attachment 117717 [details]

Reviewed by NOBODY (OOPS!).

iOS does not need to support the Cursor of WebKit. For compatibility, Cursor
is implemented as an empty class on the platform.

* Configurations/WebCore.xcconfig:
* WebCore.xcodeproj/project.pbxproj:
* platform/Cursor.h:
* platform/ios/CursorIOS.cpp: Added.
 5 files changed, 328 insertions(+), 3 deletions(-)
Comment 1 WebKit Review Bot 2011-12-02 17:44:11 PST
Attachment 117717 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 5 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 2 David Kilzer (:ddkilzer) 2011-12-04 04:23:00 PST
Comment on attachment 117717 [details]

r=me as long as you add the bug number to the ChangeLog.

May also be worth filing a bug about a shared NullCursor implementation since the WinCE port does something similar to this.
Comment 3 Benjamin Poulain 2011-12-05 22:31:59 PST
Committed r102097: <http://trac.webkit.org/changeset/102097>