Bug 73718 - [Qt] cleanup qmltests.pro
Summary: [Qt] cleanup qmltests.pro
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-02 16:16 PST by Gopal Raghavan
Modified: 2011-12-04 12:42 PST (History)
3 users (show)

See Also:

Attachments
cleanup patch (2.00 KB, patch)
2011-12-02 16:22 PST, Gopal Raghavan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gopal Raghavan 2011-12-02 16:16:02 PST 
Remove unused file WebView/tst_loadZeroSizeView.qml
Comment 1 Gopal Raghavan 2011-12-02 16:22:07 PST 
Created attachment 117710 [details]
cleanup patch

Removed unused file WebView/tst_loadZeroSizeView.qml and reordered file list.
Comment 2 Viatcheslav Ostapenko 2011-12-02 16:41:22 PST 
Comment on attachment 117710 [details]
cleanup patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117710&action=review

> Source/WebKit2/UIProcess/API/qt/tests/qmltests/qmltests.pro:NaN
>  DEFINES += QUICK_TEST_SOURCE_DIR=\"\\\"$

You've also removed QUICK_TEST_SOURCE_DIR .
Should it be removed? It is not mentioned in ChangeLog.
Comment 3 Viatcheslav Ostapenko 2011-12-02 16:45:29 PST 
(In reply to comment #2)
> (From update of attachment 117710 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=117710&action=review
> 
> > Source/WebKit2/UIProcess/API/qt/tests/qmltests/qmltests.pro:NaN
> >  DEFINES += QUICK_TEST_SOURCE_DIR=\"\\\"$
> 
> You've also removed QUICK_TEST_SOURCE_DIR .
> Should it be removed? It is not mentioned in ChangeLog.

Never mind.
Was confused by review page highlighting.
Comment 4 WebKit Review Bot 2011-12-04 12:42:21 PST 
Comment on attachment 117710 [details]
cleanup patch

Clearing flags on attachment: 117710

Committed r101963: <http://trac.webkit.org/changeset/101963>
Comment 5 WebKit Review Bot 2011-12-04 12:42:26 PST 
All reviewed patches have been landed.  Closing bug.