RESOLVED FIXED 73718
[Qt] cleanup qmltests.pro 
https://bugs.webkit.org/show_bug.cgi?id=73718
Summary [Qt] cleanup qmltests.pro
Gopal Raghavan
Reported 2011-12-02 16:16:02 PST
Remove unused file WebView/tst_loadZeroSizeView.qml
Attachments
cleanup patch (2.00 KB, patch)
2011-12-02 16:22 PST, Gopal Raghavan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gopal Raghavan
Comment 1 2011-12-02 16:22:07 PST
Created attachment 117710 [details] cleanup patch Removed unused file WebView/tst_loadZeroSizeView.qml and reordered file list.
Viatcheslav Ostapenko
Comment 2 2011-12-02 16:41:22 PST
Comment on attachment 117710 [details] cleanup patch View in context: https://bugs.webkit.org/attachment.cgi?id=117710&action=review > Source/WebKit2/UIProcess/API/qt/tests/qmltests/qmltests.pro:NaN > DEFINES += QUICK_TEST_SOURCE_DIR=\"\\\"$ You've also removed QUICK_TEST_SOURCE_DIR . Should it be removed? It is not mentioned in ChangeLog.
Viatcheslav Ostapenko
Comment 3 2011-12-02 16:45:29 PST
(In reply to comment #2) > (From update of attachment 117710 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=117710&action=review > > > Source/WebKit2/UIProcess/API/qt/tests/qmltests/qmltests.pro:NaN > > DEFINES += QUICK_TEST_SOURCE_DIR=\"\\\"$ > > You've also removed QUICK_TEST_SOURCE_DIR . > Should it be removed? It is not mentioned in ChangeLog. Never mind. Was confused by review page highlighting.
WebKit Review Bot
Comment 4 2011-12-04 12:42:21 PST
Comment on attachment 117710 [details] cleanup patch Clearing flags on attachment: 117710 Committed r101963: <http://trac.webkit.org/changeset/101963>
WebKit Review Bot
Comment 5 2011-12-04 12:42:26 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.