WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
73708
Update platform/iphone to platform/ios
https://bugs.webkit.org/show_bug.cgi?id=73708
Summary
Update platform/iphone to platform/ios
Benjamin Poulain
Reported
2011-12-02 14:53:41 PST
Created
attachment 117700
[details]
Patch Patch by Benjamin Poulain <
bpoulain@apple.com
> on 2011-12-02 Reviewed by NOBODY (OOPS!). The platform is now best known as iOS, update the platform layer accordingly. * Configurations/WebCore.xcconfig: * WebCore.gypi: * WebCore.xcodeproj/project.pbxproj: * platform/cocoa/KeyEventCocoa.mm: * platform/ios/KeyEventCodesIOS.h: Renamed from Source/WebCore/platform/iphone/KeyEventCodesIPhone.h. * platform/ios/KeyEventIOS.mm: Renamed from Source/WebCore/platform/iphone/KeyEventIPhone.mm. (WebCore::keyIdentifierForKeyEvent): (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent): (WebCore::PlatformKeyboardEvent::currentCapsLockState): (WebCore::PlatformKeyboardEvent::getCurrentModifierState): --- 9 files changed, 286 insertions(+), 254 deletions(-)
Attachments
Patch
(32.50 KB, patch)
2011-12-02 14:53 PST
,
Benjamin Poulain
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
WebKit Review Bot
Comment 1
2011-12-02 14:56:14 PST
Attachment 117700
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Traceback (most recent call last): File "Tools/Scripts/check-webkit-style", line 42, in <module> from webkitpy.style.main import CheckWebKitStyle File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/main.py", line 27, in <module> import webkitpy.style.checker as checker File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/checker.py", line 40, in <module> from checkers.changelog import ChangeLogChecker File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/checkers/changelog.py", line 30, in <module> from webkitpy.common.checkout.changelog import parse_bug_id_from_changelog File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/common/checkout/__init__.py", line 3, in <module> from .checkout import Checkout File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/common/checkout/checkout.py", line 32, in <module> from webkitpy.common.checkout.changelog import ChangeLog, parse_bug_id_from_changelog File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/common/checkout/changelog.py", line 36, in <module> from webkitpy.common.config.committers import CommitterList File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/common/config/committers.py", line 135 Contributor("Pierre Rossi", "
pierre.rossi@gmail.com
", "elproxy"), ^ SyntaxError: invalid syntax If any of these errors are false positives, please file a bug against check-webkit-style.
Benjamin Poulain
Comment 2
2011-12-02 15:36:21 PST
Committed
r101867
: <
http://trac.webkit.org/changeset/101867
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug