Add the KeyCodeConversionAndroid.cpp file, which is a partial re-land of an older file from the Android port: http://trac.webkit.org/browser/trunk/WebCore/platform/android/KeyEventAndroid.cpp?rev=56704 Add IconChromiumAndroid.cpp which nullifies the rendering of icons in file upload boxes, which is not something we want to support now. Also include ClipboardChromiumLinux.cpp and FileSystemChromiumLinux.cpp as their functionality can be re-used for Android.
Created attachment 117647 [details] Patch Note for the reviewers: An alternative solution to adding a new IconChromiumAndroid.cpp file would be to #ifdef out the implementation in IconChromium.cpp, but overall I think this is cleaner. http://codesearch.google.com/#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/platform/graphics/chromium/IconChromium.cpp&exact_package=chromium&q=IconChromium.cpp&type=cs&l=48
Thanks!
Comment on attachment 117647 [details] Patch Rejecting attachment 117647 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: webkit-commit-queue/Source/WebKit/chromium/webkit --revision 112463 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 49>At revision 112463. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/10729173
Created attachment 117858 [details] Patch for landing I have no idea where the ChangeLog disappeared to, anyway, hereby the patch for landing.
Comment on attachment 117858 [details] Patch for landing Clearing flags on attachment: 117858 Committed r102018: <http://trac.webkit.org/changeset/102018>
All reviewed patches have been landed. Closing bug.