Bug 73672 - [Chromium] Add Android keycodes and build Linux clipboard/filesystem files.
Summary: [Chromium] Add Android keycodes and build Linux clipboard/filesystem files.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peter Beverloo
Depends on: 73849
Blocks: 66687
  Show dependency treegraph
Reported: 2011-12-02 10:10 PST by Peter Beverloo
Modified: 2011-12-06 05:39 PST (History)
6 users (show)

See Also:

Patch (9.93 KB, patch)
2011-12-02 10:14 PST, Peter Beverloo
abarth: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (11.27 KB, patch)
2011-12-05 02:24 PST, Peter Beverloo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Beverloo 2011-12-02 10:10:56 PST
Add the KeyCodeConversionAndroid.cpp file, which is a partial re-land of an older file from the Android port:

Add IconChromiumAndroid.cpp which nullifies the rendering of icons in file upload boxes, which is not something we want to support now. Also include ClipboardChromiumLinux.cpp and FileSystemChromiumLinux.cpp as their functionality can be re-used for Android.
Comment 1 Peter Beverloo 2011-12-02 10:14:00 PST
Created attachment 117647 [details]

Note for the reviewers: An alternative solution to adding a new IconChromiumAndroid.cpp file would be to #ifdef out the implementation in IconChromium.cpp, but overall I think this is cleaner.

Comment 2 Peter Beverloo 2011-12-02 10:50:43 PST
Comment 3 WebKit Review Bot 2011-12-02 14:49:20 PST
Comment on attachment 117647 [details]

Rejecting attachment 117647 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
webkit-commit-queue/Source/WebKit/chromium/webkit --revision 112463 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
49>At revision 112463.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/10729173
Comment 4 Peter Beverloo 2011-12-05 02:24:28 PST
Created attachment 117858 [details]
Patch for landing

I have no idea where the ChangeLog disappeared to, anyway, hereby the patch for landing.
Comment 5 WebKit Review Bot 2011-12-05 11:10:42 PST
Comment on attachment 117858 [details]
Patch for landing

Clearing flags on attachment: 117858

Committed r102018: <http://trac.webkit.org/changeset/102018>
Comment 6 WebKit Review Bot 2011-12-05 11:10:47 PST
All reviewed patches have been landed.  Closing bug.