WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
73662
[GTK] Add downloads support to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=73662
Summary
[GTK] Add downloads support to MiniBrowser
Carlos Garcia Campos
Reported
2011-12-02 08:36:45 PST
Just for testing downloads API.
Attachments
Patch
(17.73 KB, patch)
2011-12-02 08:43 PST
,
Carlos Garcia Campos
pnormand
: review-
gustavo.noronha
: commit-queue-
Details
Formatted Diff
Diff
Updated patch
(19.25 KB, patch)
2012-04-26 03:16 PDT
,
Carlos Garcia Campos
pnormand
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1
2011-12-02 08:43:23 PST
Created
attachment 117633
[details]
Patch The ui can be improved and it doesn't scale, but it's just for testing.
WebKit Review Bot
Comment 2
2011-12-02 08:44:58 PST
Attachment 117633
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/MiniBrowser/gtk/..." exit_code: 1 Tools/MiniBrowser/gtk/BrowserDownloadsBar.h:47: The parameter name "downloadsBar" adds no information, so it should be removed. [readability/parameter_name] [5] Tools/MiniBrowser/gtk/BrowserDownloadsBar.h:48: The parameter name "download" adds no information, so it should be removed. [readability/parameter_name] [5] Tools/MiniBrowser/gtk/BrowserDownloadsBar.h:48: Extra space between WebKitDownload and *download [whitespace/declaration] [3] Tools/MiniBrowser/gtk/BrowserDownloadsBar.c:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 4 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Collabora GTK+ EWS bot
Comment 3
2011-12-02 16:59:18 PST
Comment on
attachment 117633
[details]
Patch
Attachment 117633
[details]
did not pass gtk-ews (gtk): Output:
http://queues.webkit.org/results/10688453
Philippe Normand
Comment 4
2012-04-24 07:29:46 PDT
Comment on
attachment 117633
[details]
Patch Looks good, r- mostly to get you to check EWS before landing :) The patch this one depends on landed it seems so I'd like to have green EWS before landing this one.
Carlos Garcia Campos
Comment 5
2012-04-26 03:16:10 PDT
Created
attachment 138962
[details]
Updated patch Rebased to current git master. I also had to do some changes because the downloads API has changed since I wrote this patch.
WebKit Review Bot
Comment 6
2012-04-26 03:20:30 PDT
Attachment 138962
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/MiniBrowser/gtk/..." exit_code: 1 Tools/MiniBrowser/gtk/BrowserDownloadsBar.c:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Philippe Normand
Comment 7
2012-04-26 03:44:08 PDT
Comment on
attachment 138962
[details]
Updated patch Cool stuff. Thanks!
Carlos Garcia Campos
Comment 8
2012-04-26 04:00:38 PDT
Committed
r115301
: <
http://trac.webkit.org/changeset/115301
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug