Bug 73662 – [GTK] Add downloads support to MiniBrowser

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Carlos Garcia Campos]

Just for testing downloads API.

[Carlos Garcia Campos]

Created attachment 117633 [details]
Patch

The ui can be improved and it doesn't scale, but it's just for testing.

[WebKit Review Bot]

Attachment 117633 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/MiniBrowser/gtk/..." exit_code: 1

Tools/MiniBrowser/gtk/BrowserDownloadsBar.h:47:  The parameter name "downloadsBar" adds no information, so it should be removed.  [readability/parameter_name] [5]
Tools/MiniBrowser/gtk/BrowserDownloadsBar.h:48:  The parameter name "download" adds no information, so it should be removed.  [readability/parameter_name] [5]
Tools/MiniBrowser/gtk/BrowserDownloadsBar.h:48:  Extra space between WebKitDownload and *download  [whitespace/declaration] [3]
Tools/MiniBrowser/gtk/BrowserDownloadsBar.c:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 4 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Collabora GTK+ EWS bot]

Comment on attachment 117633 [details]
Patch

Attachment 117633 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10688453

[Philippe Normand]

Comment on attachment 117633 [details]
Patch

Looks good, r- mostly to get you to check EWS before landing :) The patch this one depends on landed it seems so I'd like to have green EWS before landing this one.

[Carlos Garcia Campos]

Created attachment 138962 [details]
Updated patch

Rebased to current git master. I also had to do some changes because the downloads API has changed since I wrote this patch.

[WebKit Review Bot]

Attachment 138962 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/MiniBrowser/gtk/..." exit_code: 1
Tools/MiniBrowser/gtk/BrowserDownloadsBar.c:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Philippe Normand]

Comment on attachment 138962 [details]
Updated patch

Cool stuff. Thanks!

[Carlos Garcia Campos]

Committed r115301: <http://trac.webkit.org/changeset/115301>