Bug 73629 – [Chromium] Show placeholder even if the element is focused

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Kent Tamura]

Follows the behavior of Apple ports.

The new behavior is allowed by the standard.
http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#the-placeholder-attribute

[Kent Tamura]

Created attachment 117578 [details]
Patch

[Kent Tamura]

Comment on attachment 117578 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117578&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests. Need to update some existing placeholder tests.

Affected tests were already marked as FAIL in http://trac.webkit.org/changeset/101742.

> Source/WebCore/rendering/RenderThemeChromiumSkia.h:160
> +    int menuListInternalPadding(RenderStyle*, int paddingType) const;
> +    bool paintMediaButtonInternal(GraphicsContext*, const IntRect&, Image*);
> +    IntRect convertToPaintingRect(RenderObject* inputRenderer, const RenderObject* partRenderer, IntRect partRect, const IntRect& localOffset) const;
> +};

Note: The declaration of RenderThemeChromiumSkia starts at the first column. The current indentation of these functions and '};' are wrong.

[Kent Tamura]

Chromium bug: http://code.google.com/p/chromium/issues/detail?id=103025

[Kent Tamura]

Comment on attachment 117578 [details]
Patch

Clearing flags on attachment: 117578

Committed r101848: <http://trac.webkit.org/changeset/101848>

[Kent Tamura]

All reviewed patches have been landed.  Closing bug.