Bug 73629 - [Chromium] Show placeholder even if the element is focused
Summary: [Chromium] Show placeholder even if the element is focused
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on: 73615
Blocks:
  Show dependency tree / graph
 
Reported: 2011-12-01 23:30 PST by Kent Tamura
Modified: 2011-12-14 23:52 PST (History)
4 users (show)

See Also:

Attachments
Patch (4.25 KB, patch)
2011-12-01 23:34 PST, Kent Tamura 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2011-12-01 23:30:39 PST 
Follows the behavior of Apple ports.

The new behavior is allowed by the standard.
http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#the-placeholder-attribute
Comment 1 Kent Tamura 2011-12-01 23:34:32 PST 
Created attachment 117578 [details]
Patch
Comment 2 Kent Tamura 2011-12-01 23:38:01 PST 
Comment on attachment 117578 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117578&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests. Need to update some existing placeholder tests.

Affected tests were already marked as FAIL in http://trac.webkit.org/changeset/101742.

> Source/WebCore/rendering/RenderThemeChromiumSkia.h:160
> +    int menuListInternalPadding(RenderStyle*, int paddingType) const;
> +    bool paintMediaButtonInternal(GraphicsContext*, const IntRect&, Image*);
> +    IntRect convertToPaintingRect(RenderObject* inputRenderer, const RenderObject* partRenderer, IntRect partRect, const IntRect& localOffset) const;
> +};

Note: The declaration of RenderThemeChromiumSkia starts at the first column. The current indentation of these functions and '};' are wrong.
Comment 3 Kent Tamura 2011-12-01 23:54:21 PST 
Chromium bug: http://code.google.com/p/chromium/issues/detail?id=103025
Comment 4 Kent Tamura 2011-12-02 13:56:00 PST 
Comment on attachment 117578 [details]
Patch

Clearing flags on attachment: 117578

Committed r101848: <http://trac.webkit.org/changeset/101848>
Comment 5 Kent Tamura 2011-12-02 13:56:06 PST 
All reviewed patches have been landed.  Closing bug.