[Mac] Reference count threading violation in FormDataStreamMac.mm
Created attachment 117575 [details] Patch
Comment on attachment 117575 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117575&action=review > Source/WebCore/platform/network/mac/FormDataStreamMac.mm:62 > + DEFINE_STATIC_LOCAL(NSMapTable *, streamFieldsMap, (NSCreateMapTable(NSNonRetainedObjectMapKeyCallBacks, NSNonOwnedPointerMapValueCallBacks, 1))); I don’t think DEFINE_STATIC_LOCAL makes sense for a pointer type. Those don’t have destructors.
Comment on attachment 117575 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117575&action=review >> Source/WebCore/platform/network/mac/FormDataStreamMac.mm:62 >> + DEFINE_STATIC_LOCAL(NSMapTable *, streamFieldsMap, (NSCreateMapTable(NSNonRetainedObjectMapKeyCallBacks, NSNonOwnedPointerMapValueCallBacks, 1))); > > I don’t think DEFINE_STATIC_LOCAL makes sense for a pointer type. Those don’t have destructors. You're right. I should just use a plain old "static" here.
Created attachment 117576 [details] Patch
Committed r101813: <http://trac.webkit.org/changeset/101813>