Before freeing the item, it also should be removed from the matrix list. so that it prevent leaving dangling pointer on the matrix list.
Created attachment 117573 [details] proposal_patch
Created attachment 117574 [details] add patch number
Attachment 117573 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/efl/ChangeLog', u'Source/Web..." exit_code: 1 Source/WebKit/efl/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 117574 [details] add patch number LGTM.
Comment on attachment 117574 [details] add patch number Rejecting attachment 117574 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 10105 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 48>At revision 10105. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/10697000
Created attachment 117636 [details] rebased patch please land it manually.
Comment on attachment 117636 [details] rebased patch Rejecting attachment 117636 [details] from review queue. jungjik.lee@samsung.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights.
(In reply to comment #6) > Created an attachment (id=117636) [details] > rebased patch > > please land it manually. Jung Jik, Do not set r+ after now. Reviewer is only able to set r+. In this case, you just need to request for cq?.
(In reply to comment #8) > (In reply to comment #6) > > Created an attachment (id=117636) [details] [details] > > rebased patch > > > > please land it manually. > > Jung Jik, Do not set r+ after now. Reviewer is only able to set r+. In this case, you just need to request for cq?. Now I know, Thanks gyuyoung.
Comment on attachment 117636 [details] rebased patch Clearing flags on attachment: 117636 Committed r101887: <http://trac.webkit.org/changeset/101887>
All reviewed patches have been landed. Closing bug.