Both wtf/text/StringHash.h and wtf/text/StringImpl.cpp contain platform specific code to implement equal comparison of two character arrays. These two versions should be merged together into a common implementation.
Created attachment 118843 [details] Patch
Comment on attachment 118843 [details] Patch r=me
Committed r102631: <http://trac.webkit.org/changeset/102631>
Comment on attachment 118843 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=118843&action=review > Source/JavaScriptCore/wtf/text/AtomicString.h:142 > +inline bool operator==(const AtomicString& a, const Vector<UChar>& b) { return a.impl() && equal(static_cast<StringImpl*>(a.impl()), b.data(), b.size()); } Why is the cast needed? > Source/JavaScriptCore/wtf/text/StringImpl.h:566 > +template <typename CharTypeL, typename CharTypeR> > + ALWAYS_INLINE bool equal(const CharTypeL*, const CharTypeR*, unsigned); We don’t normally implement the second line like this. I think that this is too broad an overload for equal. It will allow you to pass any two pointers, including pointers to that aren’t even character types. Instead, I suggest overloading the equal function for all the combinations.
(In reply to comment #4) > > Source/JavaScriptCore/wtf/text/StringImpl.h:566 > > +template <typename CharTypeL, typename CharTypeR> > > + ALWAYS_INLINE bool equal(const CharTypeL*, const CharTypeR*, unsigned); > > We don’t normally indent the second line like this.