Created attachment 117472 [details] Patch Actual bug: crbug.com/85132. To support my changes to fix crbug.com/85132, I need to add a helper method to identify whether the page has custom page size style.
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Comment on attachment 117472 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117472&action=review > Source/WebCore/dom/Document.cpp:1698 > + RefPtr<RenderStyle> style = styleForPage(pageIndex); > + return style->pageSizeType() != PAGE_SIZE_AUTO; This function should not be added. You can just put all the code at at the call site in WebFrameImpl. > Source/WebKit/chromium/src/WebFrameImpl.cpp:1481 > + return frame()->document()->hasCustomPageSizeStyle(pageIndex); return frame->document()->styleForPage(pageIndex)->pageSizeType() != PAGE_SIZE_AUTO;
Comment on attachment 117472 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117472&action=review The patch contains no ChangeLog. > LayoutTests/printing/page-format-data.html:62 > + // Page size style tests. Do you think layoutTestController.hasCustomPageSizeStyle() is Chromium-specific? If so, we should make a new test in LayoutTests/chromium/printing/ directory.
(In reply to comment #3) > (From update of attachment 117472 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=117472&action=review > > The patch contains no ChangeLog. > > > LayoutTests/printing/page-format-data.html:62 > > + // Page size style tests. > > Do you think layoutTestController.hasCustomPageSizeStyle() is Chromium-specific? > If so, we should make a new test in LayoutTests/chromium/printing/ directory. LayoutTests/platform/chromium/printing/
Created attachment 117539 [details] Patch Addressed review comments and created a new test.
Comment on attachment 117539 [details] Patch Please add ChangeLog.
Comment on attachment 117539 [details] Patch WebKit API changes LGTM
Created attachment 117639 [details] Latest patch with Changelog ChangeLog added. Thanks.
fishd: Can you commit this patch for me? Thanks.
Comment on attachment 117639 [details] Latest patch with Changelog Clearing flags on attachment: 117639 Committed r101851: <http://trac.webkit.org/changeset/101851>
All reviewed patches have been landed. Closing bug.