Bug 73580 - Rollout r101743
Summary: Rollout r101743
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Raphael Kubo da Costa (:rakuco)
Depends on:
Reported: 2011-12-01 11:59 PST by Raphael Kubo da Costa (:rakuco)
Modified: 2011-12-02 07:32 PST (History)
5 users (show)

See Also:

Patch (10.16 KB, patch)
2011-12-01 12:14 PST, Raphael Kubo da Costa (:rakuco)
no flags Details | Formatted Diff | Diff
Rebased patch for landing (10.22 KB, patch)
2011-12-02 06:02 PST, Raphael Kubo da Costa (:rakuco)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa (:rakuco) 2011-12-01 11:59:04 PST
As mentioned in https://bugs.webkit.org/show_bug.cgi?id=73111#c25, linking of the Tools/ targets (EWebLauncher, DumpRenderTree and ImageDiff) is broken with r101347:

  ../../../Source/WebCore/libwebcore_efl.so.0.1.0: undefined reference to `WebCore::uidForImage(WebCore::Image*)'
  ../../../Source/WebCore/libwebcore_efl.so.0.1.0: undefined reference to `WebCore::BGRA32PremultimpliedBuffer::create()'
collect2: ld returned 1 exit status

These functions are implemented in TextureMapperQt.cpp. Alternatively, one might be interested in sharing TextureMapperCairo with GTK+ (it got committed not long ago).
Comment 1 Raphael Kubo da Costa (:rakuco) 2011-12-01 12:14:14 PST
Created attachment 117455 [details]
Comment 2 WebKit Review Bot 2011-12-02 04:16:12 PST
Comment on attachment 117455 [details]

Rejecting attachment 117455 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
- saving rejects to file Source/WebCore/platform/graphics/GraphicsLayer.h.rej
patching file Source/WebCore/platform/graphics/efl/GraphicsLayerEfl.cpp
patching file Source/WebCore/platform/graphics/efl/GraphicsLayerEfl.h
patching file Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp
patching file Source/cmake/OptionsEfl.cmake
patching file ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/10727124
Comment 3 Raphael Kubo da Costa (:rakuco) 2011-12-02 06:02:55 PST
Created attachment 117614 [details]
Rebased patch for landing
Comment 4 WebKit Review Bot 2011-12-02 07:32:21 PST
Comment on attachment 117614 [details]
Rebased patch for landing

Clearing flags on attachment: 117614

Committed r101796: <http://trac.webkit.org/changeset/101796>
Comment 5 WebKit Review Bot 2011-12-02 07:32:25 PST
All reviewed patches have been landed.  Closing bug.