Bug 73576 - V8 bindings cleanup: V8WindowErrorHandler shouldn't be directly invoking script
Summary: V8 bindings cleanup: V8WindowErrorHandler shouldn't be directly invoking script
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rafael Weinstein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-01 11:21 PST by Rafael Weinstein
Modified: 2011-12-01 15:07 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.76 KB, patch)
2011-12-01 11:23 PST, Rafael Weinstein
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Weinstein 2011-12-01 11:21:24 PST
It should be calling through V8Proxy where appropriate checks are made.
Comment 1 Rafael Weinstein 2011-12-01 11:23:10 PST
Created attachment 117449 [details]
Patch
Comment 2 Adam Barth 2011-12-01 11:50:42 PST
Comment on attachment 117449 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117449&action=review

> Source/WebCore/ChangeLog:8
> +        No tests needed. This patch is just bindings hygiene.

It's too bad this stuff isn't testable.  That means we'll probably continue to screw this up.
Comment 3 WebKit Review Bot 2011-12-01 15:07:13 PST
Comment on attachment 117449 [details]
Patch

Clearing flags on attachment: 117449

Committed r101716: <http://trac.webkit.org/changeset/101716>
Comment 4 WebKit Review Bot 2011-12-01 15:07:17 PST
All reviewed patches have been landed.  Closing bug.