webkitpy doesn't provide a way to parse htdigest files
Created attachment 117444 [details] Patch
Comment on attachment 117444 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117444&action=review You are an amazing man, Dr. Roben. Amazing man. > Tools/Scripts/webkitpy/common/net/htdigestparser.py:41 > + @staticmethod > + def parse_file(digest_file): I'm not sure I would have bothered to make it static, but in this case I don't think it matters. (I'm very anti-static methods these days, as I've been bitten by their non-mockability in the last year trying to test all of webkitpy.)
(In reply to comment #2) > (From update of attachment 117444 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=117444&action=review > > You are an amazing man, Dr. Roben. Amazing man. Aw shucks. > > Tools/Scripts/webkitpy/common/net/htdigestparser.py:41 > > + @staticmethod > > + def parse_file(digest_file): > > I'm not sure I would have bothered to make it static, but in this case I don't think it matters. (I'm very anti-static methods these days, as I've been bitten by their non-mockability in the last year trying to test all of webkitpy.) OK, I'll make it non-static. Thanks for reviewing!
Committed r101694: <http://trac.webkit.org/changeset/101694>