RESOLVED FIXED 73575
webkitpy doesn't provide a way to parse htdigest files 
https://bugs.webkit.org/show_bug.cgi?id=73575
Summary webkitpy doesn't provide a way to parse htdigest files
Adam Roben (:aroben)
Reported 2011-12-01 10:48:50 PST
webkitpy doesn't provide a way to parse htdigest files
Attachments
Patch (9.60 KB, patch)
2011-12-01 10:51 PST, Adam Roben (:aroben) 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2011-12-01 10:51:34 PST
Created attachment 117444 [details] Patch
Eric Seidel (no email)
Comment 2 2011-12-01 11:06:53 PST
Comment on attachment 117444 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117444&action=review You are an amazing man, Dr. Roben. Amazing man. > Tools/Scripts/webkitpy/common/net/htdigestparser.py:41 > + @staticmethod > + def parse_file(digest_file): I'm not sure I would have bothered to make it static, but in this case I don't think it matters. (I'm very anti-static methods these days, as I've been bitten by their non-mockability in the last year trying to test all of webkitpy.)
Adam Roben (:aroben)
Comment 3 2011-12-01 11:24:48 PST
(In reply to comment #2) > (From update of attachment 117444 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=117444&action=review > > You are an amazing man, Dr. Roben. Amazing man. Aw shucks. > > Tools/Scripts/webkitpy/common/net/htdigestparser.py:41 > > + @staticmethod > > + def parse_file(digest_file): > > I'm not sure I would have bothered to make it static, but in this case I don't think it matters. (I'm very anti-static methods these days, as I've been bitten by their non-mockability in the last year trying to test all of webkitpy.) OK, I'll make it non-static. Thanks for reviewing!
Adam Roben (:aroben)
Comment 4 2011-12-01 14:03:35 PST
Committed r101694: <http://trac.webkit.org/changeset/101694>
Note You need to log in before you can comment on or make changes to this bug.