RESOLVED FIXED 73569
Web Inspector: refactor InspectorBackendDispatcher so that it does not use JSON-serialized command templates. 
https://bugs.webkit.org/show_bug.cgi?id=73569
Summary Web Inspector: refactor InspectorBackendDispatcher so that it does not use JS...
Pavel Feldman
Reported 2011-12-01 09:42:41 PST
Patch to follow.
Attachments
Patch (12.65 KB, patch)
2011-12-01 09:46 PST, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-12-01 09:46:38 PST
Created attachment 117437 [details] Patch
Ilya Tikhonovsky
Comment 2 2011-12-01 10:35:24 PST
Comment on attachment 117437 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117437&action=review lgtm > LayoutTests/inspector/report-API-errors-expected.txt:5 > +Protocol Error: Invalid type of argument 'enabled' for method 'Console.setMonitoringXHREnabled' call. It must be 'boolean' but it is 'number'. > +Protocol Error: Invalid number of arguments for method 'Console.setMonitoringXHREnabled' call. It must have the following arguments '[{"name":"enabled","type":"boolean","optional":false}]'. > +Protocol Error: Optional callback argument for method 'Console.setMonitoringXHREnabled' call must be a function but its type is 'string'. Could you please restore the name of agent.
Ilya Tikhonovsky
Comment 3 2011-12-01 10:36:38 PST
please attach the generated file.
Pavel Feldman
Comment 4 2011-12-01 10:59:24 PST
> Could you please restore the name of agent. I don't think this is necessary. New version simplifies code and uses documented protocol method notation ("Console.setMonitoringXHREnabled").
Pavel Feldman
Comment 5 2011-12-01 11:00:13 PST
(In reply to comment #3) > please attach the generated file. It did not really change much - it's just that instead of name: { optional:, type:} it is {name:, type:, optional}. I.e. matches the way we declare it in the protocol.
Ilya Tikhonovsky
Comment 6 2011-12-01 11:18:23 PST
(In reply to comment #4) > > Could you please restore the name of agent. > > I don't think this is necessary. New version simplifies code and uses documented protocol method notation ("Console.setMonitoringXHREnabled"). Let remove Agent suffix from the backend's error messages too.
Pavel Feldman
Comment 7 2011-12-01 11:28:07 PST
> Let remove Agent suffix from the backend's error messages too. What "backend's error messages" are you talking about?
Ilya Tikhonovsky
Comment 8 2011-12-01 11:35:17 PST
(In reply to comment #7) > > Let remove Agent suffix from the backend's error messages too. > > What "backend's error messages" are you talking about? looks like the 'Agent' suffix was lost in order of introducing jsonprc. sorry.
Pavel Feldman
Comment 9 2011-12-02 00:30:33 PST
Committed r101756: <http://trac.webkit.org/changeset/101756>
Note You need to log in before you can comment on or make changes to this bug.