Patch to follow.
Created attachment 117437 [details] Patch
Comment on attachment 117437 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117437&action=review lgtm > LayoutTests/inspector/report-API-errors-expected.txt:5 > +Protocol Error: Invalid type of argument 'enabled' for method 'Console.setMonitoringXHREnabled' call. It must be 'boolean' but it is 'number'. > +Protocol Error: Invalid number of arguments for method 'Console.setMonitoringXHREnabled' call. It must have the following arguments '[{"name":"enabled","type":"boolean","optional":false}]'. > +Protocol Error: Optional callback argument for method 'Console.setMonitoringXHREnabled' call must be a function but its type is 'string'. Could you please restore the name of agent.
please attach the generated file.
> Could you please restore the name of agent. I don't think this is necessary. New version simplifies code and uses documented protocol method notation ("Console.setMonitoringXHREnabled").
(In reply to comment #3) > please attach the generated file. It did not really change much - it's just that instead of name: { optional:, type:} it is {name:, type:, optional}. I.e. matches the way we declare it in the protocol.
(In reply to comment #4) > > Could you please restore the name of agent. > > I don't think this is necessary. New version simplifies code and uses documented protocol method notation ("Console.setMonitoringXHREnabled"). Let remove Agent suffix from the backend's error messages too.
> Let remove Agent suffix from the backend's error messages too. What "backend's error messages" are you talking about?
(In reply to comment #7) > > Let remove Agent suffix from the backend's error messages too. > > What "backend's error messages" are you talking about? looks like the 'Agent' suffix was lost in order of introducing jsonprc. sorry.
Committed r101756: <http://trac.webkit.org/changeset/101756>