Bug 73568 - StyledElement: Clean up inline style accessors.
Summary: StyledElement: Clean up inline style accessors.
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
Depends on:
Reported: 2011-12-01 09:38 PST by Andreas Kling
Modified: 2011-12-01 14:23 PST (History)
2 users (show)

See Also:

Patch (22.26 KB, patch)
2011-12-01 10:45 PST, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-12-01 09:38:40 PST
The difference between inlineStyleDecl() and getInlineStyleDecl() is way too subtle. I suggest we rename getInlineStyleDecl() to ensureInlineStyleDecl().
Call sites should also store the return value in a CSSInlineStyleDeclaration*.
Furthermore, we should make StyledElement::style() explicitly virtual and decorate it with OVERRIDE.
Comment 1 Andreas Kling 2011-12-01 10:45:21 PST
Created attachment 117443 [details]
Comment 2 WebKit Review Bot 2011-12-01 14:22:58 PST
Comment on attachment 117443 [details]

Clearing flags on attachment: 117443

Committed r101707: <http://trac.webkit.org/changeset/101707>
Comment 3 WebKit Review Bot 2011-12-01 14:23:03 PST
All reviewed patches have been landed.  Closing bug.