RESOLVED FIXED 73562
Web Inspector: extract static part of the InspectorBackend from the generator. 
https://bugs.webkit.org/show_bug.cgi?id=73562
Summary Web Inspector: extract static part of the InspectorBackend from the generator.
Pavel Feldman
Reported 2011-12-01 07:37:37 PST
We should only generate the mapping between the command parameters and slots, rest of the backend is static.
Attachments
Patch (30.33 KB, patch)
2011-12-01 07:43 PST, Pavel Feldman 		timothy: review+
DetailsFormatted DiffDiff
[Generated InspectorBackendStub.js] (24.50 KB, text/plain)
2011-12-01 07:43 PST, Pavel Feldman 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-12-01 07:43:09 PST
Created attachment 117419 [details] Patch
Pavel Feldman
Comment 2 2011-12-01 07:43:52 PST
Created attachment 117420 [details] [Generated InspectorBackendStub.js]
Timothy Hatcher
Comment 3 2011-12-01 07:54:02 PST
Comment on attachment 117419 [details] Patch You need to update the "Copy Inspector Resources" and "Streamline Inspector Source" build phases in the WebCore Xcode project which has references to "InspectorBackendStub.js".
Timothy Hatcher
Comment 4 2011-12-01 07:56:01 PST
Comment on attachment 117419 [details] Patch I guess you might not need to update the Xcode project, I see the InspectorBackendStub.js file is still there. But I have been meaning to say, InspectorBackendStub.js isn't the best name for the file. They arn't stubs.
Timothy Hatcher
Comment 5 2011-12-01 08:11:55 PST
Comment on attachment 117419 [details] Patch InspectorBackendCommands.js weould be a good name now.
Pavel Feldman
Comment 6 2011-12-01 08:15:04 PST
(In reply to comment #5) > (From update of attachment 117419 [details]) > InspectorBackendCommands.js weould be a good name now. I do remember your concern and am going to resolve it.
Pavel Feldman
Comment 7 2011-12-01 08:21:09 PST
Committed r101670: <http://trac.webkit.org/changeset/101670>
Note You need to log in before you can comment on or make changes to this bug.