Bug 73562 - Web Inspector: extract static part of the InspectorBackend from the generator.
Summary: Web Inspector: extract static part of the InspectorBackend from the generator.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-01 07:37 PST by Pavel Feldman
Modified: 2011-12-01 08:21 PST (History)
10 users (show)

See Also:


Attachments
Patch (30.33 KB, patch)
2011-12-01 07:43 PST, Pavel Feldman
timothy: review+
Details | Formatted Diff | Diff
[Generated InspectorBackendStub.js] (24.50 KB, text/plain)
2011-12-01 07:43 PST, Pavel Feldman
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-12-01 07:37:37 PST
We should only generate the mapping between the command parameters and slots, rest of the backend is static.
Comment 1 Pavel Feldman 2011-12-01 07:43:09 PST
Created attachment 117419 [details]
Patch
Comment 2 Pavel Feldman 2011-12-01 07:43:52 PST
Created attachment 117420 [details]
[Generated InspectorBackendStub.js]
Comment 3 Timothy Hatcher 2011-12-01 07:54:02 PST
Comment on attachment 117419 [details]
Patch

You need to update the "Copy Inspector Resources" and "Streamline Inspector Source" build phases in the WebCore Xcode project which has references to "InspectorBackendStub.js".
Comment 4 Timothy Hatcher 2011-12-01 07:56:01 PST
Comment on attachment 117419 [details]
Patch

I guess you might not need to update the Xcode project, I see the InspectorBackendStub.js file is still there.

But I have been meaning to say, InspectorBackendStub.js isn't the best name for the file. They arn't stubs.
Comment 5 Timothy Hatcher 2011-12-01 08:11:55 PST
Comment on attachment 117419 [details]
Patch

InspectorBackendCommands.js weould be a good name now.
Comment 6 Pavel Feldman 2011-12-01 08:15:04 PST
(In reply to comment #5)
> (From update of attachment 117419 [details])
> InspectorBackendCommands.js weould be a good name now.

I do remember your concern and am going to resolve it.
Comment 7 Pavel Feldman 2011-12-01 08:21:09 PST
Committed r101670: <http://trac.webkit.org/changeset/101670>