Bug 73557 – check-webkit-style should do sanity checks of build.webkit.org-config/config.json

• Status: NEW
• Component: Tools / Tests

[Adam Roben (:aroben)]

It would be nice if check-webkit-style could so some sanity checks of build.webkit.org-config/config.json. Some good checks include:

1) File is valid JSON
2) All slaves have "name" and "platform" properties
3) All builders have "name", "type", "builder", "platform", "configuration", "architectures", and "slavenames" properties
4) All schedulers have "name", "type", and "builderNames" properties
5) Builders only use slaves that are listed in the "slaves" array
6) Schedulers only use builders that are listed in the "builders" array
7) Each slave is used by at least one builder
8) Each builder is used by only a single scheduler
9) All slaves used by a particular builder have the same platform as that builder
10) All builders used by a particular scheduler have the same platform as that scheduler
11) Builders only use triggers that are listed in the "schedulers" array

That would be a great start and doesn't require any information from outside this file.

There are some other checks that would require outside information to perform. These might be harder to implement and less useful than the ones above. Such as:

12) All "platform" properties are valid
13) All "type" properties are valid
14) All "configuration" properties are valid

[Adam Roben (:aroben)]

(In reply to comment #0)
> 1) File is valid JSON

This is now bug 73590.