Bug 73553 - eliminate find_test_files from Port class
Summary: eliminate find_test_files from Port class
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-01 04:37 PST by Ilya Tikhonovsky
Modified: 2023-03-22 16:32 PDT (History)
6 users (show)

See Also:


Attachments
Patch (17.86 KB, patch)
2011-12-01 04:49 PST, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff
Patch (17.78 KB, patch)
2011-12-01 05:05 PST, Ilya Tikhonovsky
dpranke: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2011-12-01 04:37:13 PST
rebaseline.py and chromium_gpu.py use Port.find_test_files() the same way as it is used in Port.tests()
I'd like to replace all calls to find_test_files with tests and eliminate find_tests_files.
Also I'll move static functions close to their usage.
Comment 1 Ilya Tikhonovsky 2011-12-01 04:49:14 PST
Created attachment 117400 [details]
Patch
Comment 2 Ilya Tikhonovsky 2011-12-01 05:05:37 PST
Created attachment 117401 [details]
Patch
Comment 3 Dirk Pranke 2011-12-01 14:03:05 PST
adding rniwa to this since he has also been hacking on port.tests() and reftest-related changes.
Comment 4 Ilya Tikhonovsky 2011-12-02 00:44:36 PST
Committed r101757: <http://trac.webkit.org/changeset/101757>
Comment 5 Roger Fong 2012-12-12 16:34:44 PST
Just ran across this today:
Something seems amiss in base.py.

 	520	    def is_reference_html_file(filesystem, dirname, filename): 
 	521	        if filename.startswith('ref-') or filename.endswith('notref-'): 
 	522	            return True


First off, it seems weird that we're using prefixes instead of suffixes. 
Seems like that wouldn't work so well given that all the test names are given meaning and could being with ref- arbitrarily.

Secondly, endsWith(notref-')
?

That seems a little off as well...
Comment 6 Dirk Pranke 2012-12-12 16:38:56 PST
ref- and notref- prefixes come from the w3c's naming conventions. I think you're correct about the endswith being a problem, though.

Are you finding any existing tests that do start with ref- that would cause a problem?
Comment 7 Roger Fong 2012-12-12 16:43:17 PST
(In reply to comment #6)
> ref- and notref- prefixes come from the w3c's naming conventions. I think you're correct about the endswith being a problem, though.

I'll go ahead and fix that up then.

> Are you finding any existing tests that do start with ref- that would cause a problem?

I don't see any no. Just thinking it might be a concern in the future...