Bug 73553 – eliminate find_test_files from Port class

• Status: REOPENED
• Component: Tools / Tests

[Ilya Tikhonovsky]

rebaseline.py and chromium_gpu.py use Port.find_test_files() the same way as it is used in Port.tests()
I'd like to replace all calls to find_test_files with tests and eliminate find_tests_files.
Also I'll move static functions close to their usage.

[Ilya Tikhonovsky]

Created attachment 117400 [details]
Patch

[Ilya Tikhonovsky]

Created attachment 117401 [details]
Patch

[Dirk Pranke]

adding rniwa to this since he has also been hacking on port.tests() and reftest-related changes.

[Ilya Tikhonovsky]

Committed r101757: <http://trac.webkit.org/changeset/101757>

[Roger Fong]

Just ran across this today:
Something seems amiss in base.py.

 	520	    def is_reference_html_file(filesystem, dirname, filename): 
 	521	        if filename.startswith('ref-') or filename.endswith('notref-'): 
 	522	            return True


First off, it seems weird that we're using prefixes instead of suffixes. 
Seems like that wouldn't work so well given that all the test names are given meaning and could being with ref- arbitrarily.

Secondly, endsWith(notref-')
?

That seems a little off as well...

[Dirk Pranke]

ref- and notref- prefixes come from the w3c's naming conventions. I think you're correct about the endswith being a problem, though.

Are you finding any existing tests that do start with ref- that would cause a problem?

[Roger Fong]

(In reply to comment #6)
> ref- and notref- prefixes come from the w3c's naming conventions. I think you're correct about the endswith being a problem, though.

I'll go ahead and fix that up then.

> Are you finding any existing tests that do start with ref- that would cause a problem?

I don't see any no. Just thinking it might be a concern in the future...