Bug 73551 - Support charset ISO_8859-X as an alias to ISO-8859-X
Summary: Support charset ISO_8859-X as an alias to ISO-8859-X
Status: UNCONFIRMED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-01 04:22 PST by Ismail Donmez
Modified: 2011-12-02 08:45 PST (History)
1 user (show)

See Also:


Attachments
Patch implementing the proposed alias additions. (2.05 KB, patch)
2011-12-01 04:24 PST, Ismail Donmez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ismail Donmez 2011-12-01 04:22:44 PST
I came to know a public website which uses ISO_8859-9 as charset. Looking at http://www.iana.org/assignments/character-sets these ISO_8859-X variants are just an alias for ISO-8859-X. I will attach a patch to support the ones with underscore as an alias the original one.
Comment 1 Ismail Donmez 2011-12-01 04:24:00 PST
Created attachment 117397 [details]
Patch implementing the proposed alias additions.
Comment 2 Alexey Proskuryakov 2011-12-01 11:57:07 PST
Do these work in both Firefox and IE?

You did not flag the patch for review, which I presume means that you plan to add tests.
Comment 3 Alexey Proskuryakov 2011-12-01 11:58:07 PST
(the tests would go to fast/encoding/char-decoding.html)
Comment 4 Ismail Donmez 2011-12-01 12:08:01 PST
(In reply to comment #2)
> Do these work in both Firefox and IE?

Works with Firefox as they have these aliases (checked xulrunner code & tested Firefox myself). IE, I honestly don't know I'll test it.

> You did not flag the patch for review, which I presume means that you plan to add tests.

I forgot to flag it for review but I would like to add a testcase but never wrote one, what would be a good way to test this, any tips?

Thanks!
Comment 5 Alexey Proskuryakov 2011-12-01 14:38:06 PST
The test that I mentioned checks many encodings, you should just add these to it.
Comment 6 Ismail Donmez 2011-12-02 05:44:42 PST
(In reply to comment #5)
> The test that I mentioned checks many encodings, you should just add these to it.

Those checks look limited shall I add tests for each ISO_8859-X encoding?
Comment 7 Alexey Proskuryakov 2011-12-02 08:45:38 PST
Yes. Checking one non-ASCII character for each would be sufficient.