Bug 73551 – Support charset ISO_8859-X as an alias to ISO-8859-X

• Status: RESOLVED
• Resolution: CONFIGURATION CHANGED
• Component: DOM

[Ismail Donmez]

I came to know a public website which uses ISO_8859-9 as charset. Looking at http://www.iana.org/assignments/character-sets these ISO_8859-X variants are just an alias for ISO-8859-X. I will attach a patch to support the ones with underscore as an alias the original one.

[Ismail Donmez]

Created attachment 117397 [details]
Patch implementing the proposed alias additions.

[Alexey Proskuryakov]

Do these work in both Firefox and IE?

You did not flag the patch for review, which I presume means that you plan to add tests.

[Alexey Proskuryakov]

(the tests would go to fast/encoding/char-decoding.html)

[Ismail Donmez]

(In reply to comment #2)
> Do these work in both Firefox and IE?

Works with Firefox as they have these aliases (checked xulrunner code & tested Firefox myself). IE, I honestly don't know I'll test it.

> You did not flag the patch for review, which I presume means that you plan to add tests.

I forgot to flag it for review but I would like to add a testcase but never wrote one, what would be a good way to test this, any tips?

Thanks!

[Alexey Proskuryakov]

The test that I mentioned checks many encodings, you should just add these to it.

[Ismail Donmez]

(In reply to comment #5)
> The test that I mentioned checks many encodings, you should just add these to it.

Those checks look limited shall I add tests for each ISO_8859-X encoding?

[Alexey Proskuryakov]

Yes. Checking one non-ASCII character for each would be sufficient.

[Anne van Kesteren]

We should be aligned with https://encoding.spec.whatwg.org now which includes this mapping.

Though it doesn't include all mappings suggested by this patch, so this is a partial WONTFIX as well.